fix: remove getAvailableIntegrations and start using the other call we already do #6144
+7
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khendrikse
force-pushed
the
cpla-2605/remove-get-available-integrations
branch
from
a6b005f to
b3df094
Compare
|
This pull request adds or modifies JavaScript ( |
serhalp
approved these changes
Mar 19, 2025
| @@ -62,8 +53,9 @@ export const mergeIntegrations = async function ({ | |||
|
|
|||
| return { | |||
| slug: integration.slug, | |||
| version: integration.hostSiteUrl, | |||
There was a problem hiding this comment.
@serhalp wait gimme more info
There was a problem hiding this comment.
Just confused about previously setting a field called "version" to a URL!
There was a problem hiding this comment.
yeah it's called 'version' because it's the site version
DanielSLew
approved these changes
Mar 19, 2025
khendrikse
changed the title
|
This pull request adds or modifies JavaScript ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We merge extensions that come from our extension API and from the netlify config. For some reason we were still calling an old endpoint to get extensions from our API again.
I've removed the call to the old endpoint and am using the extensions we already fetched.
I think this logic was there because we tried to support installing extensions from within the netlify.toml. But we do not have that documented, nor do we currently support it.
Check old issue: https://github.com/netlify/pod-composable-tooling/issues/269
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #<replace_with_issue_number>
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)