Skip to content

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Oct 17, 2025

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #<replace_with_issue_number>


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

success: boolean
severityCode: number
logs: Logs | undefined
logs: BufferedLogs | undefined
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should overall be LogOutput.

Using BufferedLogs here (the difference is optional outputFlusher in BufferedLogs), because that's what was used before #6698 and this is meant to "fix" a type breaking change.

@pieh pieh marked this pull request as ready for review October 20, 2025 07:31
@pieh pieh requested a review from a team as a code owner October 20, 2025 07:31
@pieh pieh merged commit 654775b into main Oct 20, 2025
56 of 67 checks passed
@pieh pieh deleted the fix/buildSite-return-types branch October 20, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants