Skip to content

feat!: run build by default before deploy #7195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: nathanhoule/cpla-2545-change-ntl-deploy-to-build-by-default--refactor-types
Choose a base branch
from
Draft

feat!: run build by default before deploy #7195

wants to merge 1 commit into from

Conversation

ndhoule
Copy link
Contributor

@ndhoule ndhoule commented Apr 10, 2025

  • refactor: type commander options in deploy command
  • refactor: do all argv parsing in createDeployCommand
  • feat!: run build before deploy

@github-actions GitHub Actions
Copy link

📊 Benchmark results

Comparing with 33b60ba

  • Dependency count: 1,237 (no change)
  • Package size: 311 MB (no change)
  • Number of ts-expect-error directives: 420 ⬇️ 0.48% decrease vs. 33b60ba

@ndhoule ndhoule changed the base branch from main to nathanhoule/cpla-2545-change-ntl-deploy-to-build-by-default--refactor-types April 10, 2025 23:00
@ndhoule ndhoule force-pushed the nathanhoule/cpla-2545-change-ntl-deploy-to-build-by-default branch 3 times, most recently from 714bf0c to fa80263 Compare April 11, 2025 21:43
@ndhoule
feat!: run build before deploy
5f44426 
This small change updates the `deploy` command to run the configured
`build` command before deployment.

Users who prefer the previous behavior can opt out by specifying
`--build=false` when running `netlify deploy`.
@ndhoule ndhoule force-pushed the nathanhoule/cpla-2545-change-ntl-deploy-to-build-by-default branch from fa80263 to 5f44426 Compare April 11, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ndhoule