Skip to content

fix(deps): update dependency eslint to v8 #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2022
Merged

fix(deps): update dependency eslint to v8 #321

merged 2 commits into from
Apr 1, 2022

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 11, 2021 •
edited
Loading

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) ^7.21.0 -> ^8.0.0 age adoption passing confidence

Release Notes

eslint/eslint

v8.12.0

Compare Source

Features
  • 685a67a feat: fix logic for top-level this in no-invalid-this and no-eval (#​15712) (Milos Djermanovic)
Chores
  • 18f5e05 chore: padding-line-between-statements remove useless additionalItems (#​15706) (Martin Sadovy)

v8.11.0

Compare Source

Features

  • 800bd25 feat: add destructuredArrayIgnorePattern option in no-unused-vars (#​15649) (Nitin Kumar)
  • 8933fe7 feat: Catch undefined and Boolean() in no-constant-condition (#​15613) (Jordan Eldredge)
  • f90fd9d feat: Add ESLint favicon to the HTML report document (#​15671) (Mahdi Hosseinzadeh)
  • 57b8a57 feat: valid-typeof always ban undefined (#​15635) (Zzzen)

Bug Fixes

  • 6814922 fix: escaping for square brackets in ignore patterns (#​15666) (Milos Djermanovic)
  • c178ce7 fix: extend the autofix range in comma-dangle to ensure the last element (#​15669) (Milos Djermanovic)

Documentation

  • c481cec docs: add fast-eslint-8 to atom integrations (userguide) (#​15695) (db developer)
  • d2255db docs: Add clarification about eslint-enable (#​15680) (dosisod)
  • 8b9433c docs: add object pattern to first section of computed-property-spacing (#​15679) (Milos Djermanovic)
  • de800c3 docs: link to minimatch docs added. (#​15688) (Gaurav Tewari)
  • 8f675b1 docs: sort-imports add single named import example (#​15675) (Arye Eidelman)

Chores

v8.10.0

Compare Source

Features

  • 6e2c325 feat: Add ignoreOnInitialization option to no-shadow rule (#​14963) (Soufiane Boutahlil)
  • 115cae5 feat: --debug prints time it takes to parse a file (#​15609) (Bartek Iwańczuk)
  • 345e70d feat: Add onlyOneSimpleParam option to no-confusing-arrow rule (#​15566) (Gautam Arora)

Bug Fixes

  • cdc5802 fix: Avoid __dirname for built-in configs (#​15616) (DoZerg)
  • ee7c5d1 fix: false positive in camelcase with combined properties (#​15581) (Nitin Kumar)

Documentation

Chores

v8.9.0

Compare Source

Features

  • 68f64a9 feat: update eslint-scope to ignore "use strict" directives in ES3 (#​15595) (Milos Djermanovic)
  • db57639 feat: add es2016, es2018, es2019, and es2022 environments (#​15587) (Milos Djermanovic)
  • 2dc38aa feat: fix bug with arrow function return types in function-paren-newline (#​15541) (Milos Djermanovic)
  • 6f940c3 feat: Implement FlatRuleTester (#​15519) (Nicholas C. Zakas)

Documentation

  • 570a036 docs: add one-var example with for-loop initializer (#​15596) (Milos Djermanovic)
  • 417191d docs: Remove the $ prefix in terminal commands (#​15565) (Andreas Lewis)
  • 389ff34 docs: add missing Variable#scope property in the scope manager docs (#​15571) (Milos Djermanovic)
  • f63795d docs: no-eval replace dead link with working one (#​15568) (rasenplanscher)
  • 0383591 docs: Remove old Markdown issue template (#​15556) (Brandon Mills)
  • a8dd5a2 docs: add 'when not to use it' section in no-duplicate-case docs (#​15563) (Milos Djermanovic)
  • 1ad439e docs: add missed verb in docs (#​15550) (Jeff Mosawy)

Chores

v8.8.0

Compare Source

Features
Documentation

v8.7.0

Compare Source

Features

  • 19ad061 feat: no-restricted-imports support casing (#​15439) (gfyoung)
  • 564ecdb feat: Support arbitrary module namespace names in no-restricted-imports (#​15491) (Milos Djermanovic)
  • 968a02a feat: Support arbitrary module namespace names in no-useless-rename (#​15493) (Milos Djermanovic)
  • 0d2b9a6 feat: move eslint --init to @​eslint/create-config (#​15150) (唯然)
  • 127f524 feat: false negative with property option in id-match (#​15474) (Nitin Kumar)
  • 359b2c1 feat: Support arbitrary module namespace names in the camelcase rule (#​15490) (Milos Djermanovic)
  • 3549571 feat: Support arbitrary module namespace names in the quotes rule (#​15479) (Milos Djermanovic)
  • 5563c45 feat: Support arbitrary module namespace names in keyword-spacing (#​15481) (Milos Djermanovic)
  • fd3683f feat: Support arbitrary module namespace names in no-restricted-exports (#​15478) (Milos Djermanovic)

Bug Fixes

  • a8db9a5 fix: no-invalid-this false positive in class field initializer (#​15495) (Milos Djermanovic)
  • 02d6426 fix: Correctly consume RuleTester statics (#​15507) (Brad Zacher)
  • db15802 fix: Add property fatalErrorCount to ignored file results (#​15520) (Francesco Trotta)
  • 03ac8cf fix: Prevent false positives with no-constant-condition (#​15486) (Jordan Eldredge)

Documentation

  • f50f849 docs: Update CLI docs to prefer local install (#​15513) (Nicholas C. Zakas)
  • 0469eb1 docs: Update shell code fences for new website (#​15522) (Olga)

Chores

v8.6.0

Compare Source

Features

  • 6802a54 feat: handle logical assignment in no-self-assign (#​14152) (Zzzen)
  • 3b38018 feat: allow to define eslint-disable-next-line in multiple lines (#​15436) (Nitin Kumar)
  • 9d6fe5a feat: false negative with onlyDeclarations + properties in id-match (#​15431) (Nitin Kumar)

Documentation

Chores

  • 3a384fc chore: Upgrade espree to 9.3.0 (#​15473) (Brandon Mills)
  • 1443cc2 chore: Update blogpost.md.ejs (#​15468) (Nicholas C. Zakas)
  • 28e907a refactor: remove unused parameter in linter.js (#​15451) (Milos Djermanovic)
  • eaa08d3 test: add tests for allowReserved parser option with flat config (#​15450) (Milos Djermanovic)

v8.5.0

Compare Source

Features

Bug Fixes

  • 7d832d4 fix: improve prefer-template fixer (#​15230) (Nitin Kumar)
  • 981fb48 fix: do not report global references in id-match rule (#​15420) (Nitin Kumar)
  • f13d4a6 fix: improve autofix of prefer-object-has-own (#​15419) (Nitin Kumar)
  • f4559a0 fix: add helpful message when test case has non-string code/name (#​15425) (Bryan Mishkin)

Documentation

  • 314c84c docs: add an incorrect code example in for-direction (#​15434) (Holger Jeromin)
  • 3928175 docs: add destructuring examples for computed-property-spacing (#​15423) (Nitin Kumar)
  • a53e59e docs: add more examples for array-element-newline rule (#​15427) (Nitin Kumar)
  • 74cf0a0 docs: update CLA info (#​15370) (Nitin Kumar)
  • e84195e docs: fix heading level for an option in class-methods-use-this rule (#​15399) (Takuya Fukuju)

Chores

  • 225f211 test: add destructuring test cases for computed-property-spacing (#​15424) (Nitin Kumar)
  • f2c7ba6 ci: use node v16 for macOS and windows jobs (#​15418) (Nitin Kumar)

v8.4.1

Compare Source

Bug Fixes

  • 234e3d9 fix: revert changes to reported locations in max-lines-per-function (#​15397) (Milos Djermanovic)

Documentation

  • fa4d483 docs: fix typo in example for sort-keys rule (#​15393) (Nitin Kumar)

v8.4.0

Compare Source

Features

Bug Fixes

  • 4940cc5 fix: mark --rulesdir option as deprecated in CLI docs (#​15310) (Kevin Partington)

Documentation

  • 54deec5 docs: update integrations.md (#​15380) (Vlad Sholokhov)
  • fa0423a docs: fix typo in PR template (#​15365) (Nitin Kumar)
  • e233920 docs: enable a few more markdownlint rules and fix violations (#​15368) (Bryan Mishkin)
  • 632176d docs: Dedent needlessly indented example in getter-return docs (#​15363) (Jordan Eldredge)
  • 4497e88 docs: Update release notes blog post template (#​15285) (Nicholas C. Zakas)

Chores

v8.3.0

Compare Source

Features

  • 60b0a29 feat: add allowProperties option to require-atomic-updates (#​15238) (Milos Djermanovic)
  • 79278a1 feat: update no-use-before-define for class static blocks (#​15312) (Milos Djermanovic)
  • ddd01dc feat: update no-redeclare for class static blocks (#​15313) (Milos Djermanovic)
  • de69cec feat: update no-inner-declarations for class static blocks (#​15290) (Milos Djermanovic)
  • e2fe7ef feat: support for private-in syntax (fixes #​14811) (#​15060) (Yosuke Ota)
  • 34bc8d7 feat: Update espree and eslint-scope (#​15338) (Brandon Mills)
  • b171cd7 feat: update max-depth for class static blocks (#​15316) (Milos Djermanovic)
  • 6487df3 feat: update padded-blocks for class static blocks (#​15333) (Milos Djermanovic)
  • 194f36d feat: update the complexity rule for class static blocks (#​15328) (Milos Djermanovic)
  • 3530337 feat: update the indent rule for class static blocks (#​15324) (Milos Djermanovic)
  • f03cd14 feat: update lines-around-comment for class static blocks (#​15323) (Milos Djermanovic)
  • 5c64747 feat: update brace-style for class static blocks (#​15322) (Milos Djermanovic)
  • df2f1cc feat: update max-statements for class static blocks (#​15315) (Milos Djermanovic)
  • fd5a0b8 feat: update prefer-const for class static blocks (#​15325) (Milos Djermanovic)
  • b3669fd feat: code path analysis for class static blocks (#​15282) (Milos Djermanovic)
  • 15c1397 feat: update eslint-scope for class static blocks (#​15321) (Milos Djermanovic)
  • 1a1bb4b feat: update one-var for class static blocks (#​15317) (Milos Djermanovic)
  • 9b666e0 feat: update padding-line-between-statements for class static blocks (#​15318) (Milos Djermanovic)
  • d3a267f feat: update class-methods-use-this for class static blocks (#​15298) (Milos Djermanovic)
  • cdaa541 feat: update no-lone-blocks for class static blocks (#​15295) (Milos Djermanovic)
  • 8611538 feat: update block-spacing for class static blocks (#​15297) (Milos Djermanovic)
  • 7b56844 feat: update keyword-spacing for class static blocks (#​15289) (Milos Djermanovic)
  • ea18711 feat: update no-extra-semi for class static blocks (#​15287) (Milos Djermanovic)
  • 0f0971f feat: update semi rule for class static blocks (#​15286) (Milos Djermanovic)
  • abe740c feat: add examples for block-scoped-var with class static blocks (#​15302) (Milos Djermanovic)
  • 0338fd2 feat: Normalize ecmaVersion to eslint-scope when using custom parser (#​15268) (Yosuke Ota)

Bug Fixes

  • 8aa7645 fix: update vars-on-top for class static blocks (#​15306) (Milos Djermanovic)
  • 479a4cb fix: update semi-style for class static blocks (#​15309) (Milos Djermanovic)
  • 6d1c666 fix: update no-invalid-this and no-eval for class static blocks (#​15300) (Milos Djermanovic)

Documentation

  • 6b85426 docs: Expand --debug option description in the CLI documentation (#​15308) (darkred)
  • 3ae5258 docs: the strict rule does not apply to class static blocks (#​15314) (Milos Djermanovic)
  • 9309841 docs: Remove inconsistent colon in pull request docs (#​15303) (Jordan Eldredge)
  • da238cc docs: remove deprecation note from lines-around-comment (#​15293) (Milos Djermanovic)
  • 1055f16 docs: no-unused-expressions - class static blocks don't have directives (#​15283) (Milos Djermanovic)
  • 4c55216 docs: Add variables option to no-use-before-define (#​15276) (Mathias Rasmussen)

Chores

  • edd8d24 chore: upgrade eslint-visitor-keys for class static blocks (#​15277) (Milos Djermanovic)

v8.2.0

Compare Source

Features

  • c9fefd2 feat: report class evaluation TDZ errors in no-use-before-define (#​15134) (Milos Djermanovic)

Documentation

  • c415c04 docs: Use string rule severity in CLI examples (#​15253) (Kevin Partington)
  • 12b627d docs: fix typo in working-with-rules.md (#​15233) (Nitin Kumar)
  • a86ffc0 docs: fix broken anchor in configuration files (#​15223) (Pierre Berger)
  • ee8af5f docs: Link to unit tests from rule documentation (#​15207) (Brandon Mills)
  • 1c0ca3c docs: add ci and perf tags for commit (#​15215) (Nitin Kumar)

Build Related

  • 796587a build: upgrade eslint-release to v3.2.0 to support conventional commits (#​15246) (Milos Djermanovic)

Chores

v8.1.0

Compare Source

v8.0.1

Compare Source

v8.0.0

Compare Source

Configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 11, 2021
@renovate renovate bot force-pushed the renovate/eslint-8.x branch from 2201916 to b9a56f3 Compare October 11, 2021 01:23
@ehmicky
Copy link
Contributor

ehmicky commented Oct 11, 2021 •
edited
Loading

ESLint v8 is breaking several ESLint plugins. We should only merge once those are fixed:

@ehmicky ehmicky self-requested a review October 11, 2021 13:11
ehmicky
ehmicky suggested changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@ehmicky ehmicky self-assigned this Oct 11, 2021
@ehmicky ehmicky added type: chore work needed to keep the product and development running smoothly and removed type: bug code to address defects in shipped code labels Oct 11, 2021
@ehmicky ehmicky mentioned this pull request Oct 11, 2021
Merged
1 task
@renovate renovate bot force-pushed the renovate/eslint-8.x branch from b9a56f3 to b47e45e Compare October 12, 2021 16:37
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 12, 2021
@renovate renovate bot force-pushed the renovate/eslint-8.x branch from f3348c8 to 870c8e2 Compare October 12, 2021 17:04
@ehmicky ehmicky removed the type: bug code to address defects in shipped code label Oct 12, 2021
@JanFellner JanFellner mentioned this pull request Nov 25, 2021
Closed
@XhmikosR XhmikosR mentioned this pull request Jan 8, 2022
Merged
2 tasks
@ehmicky
Copy link
Contributor

ehmicky commented Feb 10, 2022

It seems like the main problem is now due to eslint-plugin-node not being maintained anymore.
A work eslint-plugin-n is available. We should switch to it.

@ehmicky ehmicky mentioned this pull request Feb 21, 2022
Closed
1 task
@renovate renovate bot force-pushed the renovate/eslint-8.x branch from ba94450 to d635721 Compare February 21, 2022 17:08
@renovate
Copy link
Contributor Author

renovate bot commented Feb 21, 2022

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm WARN using --force Recommended protections disabled.
npm notice 
npm notice New minor version of npm available! 8.3.1 -> 8.5.1
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.1>
npm notice Run `npm install -g [email protected]` to update!
npm notice 
npm WARN using --force Recommended protections disabled.
chmod: cannot access '/home/ubuntu/.npm': No such file or directory
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint
npm ERR!   eslint@"^8.0.0" from the root project
npm ERR!   peer eslint@"^7.5.0 || ^8.0.0" from @babel/[email protected]
npm ERR!   node_modules/@babel/eslint-parser
npm ERR!     @babel/eslint-parser@"^7.13.8" from the root project
npm ERR!   17 more (@typescript-eslint/eslint-plugin, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^7.12.1" from [email protected]
npm ERR! node_modules/eslint-config-standard
npm ERR!   eslint-config-standard@"^16.0.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^7.12.1" from [email protected]
npm ERR!   node_modules/eslint-config-standard
npm ERR!     eslint-config-standard@"^16.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate-cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2022-02-21T17_08_47_134Z-debug-0.log

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Feb 21, 2022
@ehmicky ehmicky mentioned this pull request Apr 1, 2022
Merged
2 tasks
@ehmicky ehmicky force-pushed the renovate/eslint-8.x branch from d635721 to 3641bb4 Compare April 1, 2022 15:59
@ehmicky ehmicky self-requested a review April 1, 2022 16:00
@kodiakhq kodiakhq bot merged commit 473d3bc into main Apr 1, 2022
@kodiakhq kodiakhq bot deleted the renovate/eslint-8.x branch April 1, 2022 16:01
@token-generator-app token-generator-app bot mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

+1 more reviewer

@ehmicky ehmicky ehmicky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ehmicky ehmicky

Labels

automerge type: bug code to address defects in shipped code type: chore work needed to keep the product and development running smoothly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ehmicky @renovate-bot