NETOBSERV-2375: make consistent status handling by jotak · Pull Request #2520 · netobserv/netobserv-operator

jotak · 2026-03-10T13:22:14Z

Description

Address some old "TODOs" in status management. All statuses now follow this pattern:

They are initialized unknown
When controller found unused, status set to unused
At any point, if an error occurs, it's set with that error
Deployment/DaemonSet check progress set status either as InProgress, or Ready
New Degraded condition can be optionally set; a degraded status does not prevent it from being "ready".

Make the LokiStack status fit in this model (it was previously using an entirely different pattern)

Also, previously, in 2 different places LokiStack was fetched to get its status (for propagating status into FlowCollector status and into console plugin config) Now consolidated into a single entry point to get the loki status.

Status changes:

New status: WaitingEBPFAgents
New status: WaitingWebConsole
New status: WaitingDemoLoki
New status: WaitingLokiStack
Renamed status: WaitingFlowCollectorLegacy => WaitingFlowCollectorController
Removed: LokiIssue and LokiWarning

Dependencies

NETOBSERV-2375: adapt statuses to operator changes; sort conditions netobserv-web-console#1319

Checklist

Does the changes in PR need specific configuration or environment set up for testing?
- if so please describe it in PR description.
I have added thorough unit tests for the change.
QE requirements (check 1 from the list):
- Standard QE validation, with pre-merge tests unless stated otherwise.
- Regression tests only (e.g. refactoring with no user-facing change).
- No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

openshift-ci-robot · 2026-03-10T13:22:19Z

@jotak: This pull request references NETOBSERV-2375 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Address some old "TODOs" in status management. All statuses now follow this pattern:

They are initialized unknown

When controller found unused, status set to unused

At any point, if an error occurs, it's set with that error

Deployment/DaemonSet check progress set status either as InProgress, or Ready

New Degraded condition can be optionally set; a degraded status does not prevent it from being "ready".

Make the LokiStack status fit in this model (it was previously using an entirely different pattern)

Also, previously, in 2 different places LokiStack was fetched to get its status (for propagating status into FlowCollector status and into console plugin config) Now consolidated into a single entry point to get the loki status.

Status changes:

New status: EBPFAgents

New status: WebConsole

New status: DemoLoki

New status: LokiStack

Renamed status: FlowCollectorLegacy => FlowCollectorController

Removed: LokiIssue and LokiWarning

Dependencies

n/a

Checklist

Does the changes in PR need specific configuration or environment set up for testing?

if so please describe it in PR description.

I have added thorough unit tests for the change.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-10T13:22:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oliviercazade for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-03-10T13:25:19Z

@jotak: This pull request references NETOBSERV-2375 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Address some old "TODOs" in status management. All statuses now follow this pattern:

They are initialized unknown

When controller found unused, status set to unused

At any point, if an error occurs, it's set with that error

Deployment/DaemonSet check progress set status either as InProgress, or Ready

New Degraded condition can be optionally set; a degraded status does not prevent it from being "ready".

Make the LokiStack status fit in this model (it was previously using an entirely different pattern)

Also, previously, in 2 different places LokiStack was fetched to get its status (for propagating status into FlowCollector status and into console plugin config) Now consolidated into a single entry point to get the loki status.

Status changes:

New status: EBPFAgents

New status: WebConsole

New status: DemoLoki

New status: LokiStack

Renamed status: FlowCollectorLegacy => FlowCollectorController

Removed: LokiIssue and LokiWarning

Dependencies

NETOBSERV-2375: adapt statuses to operator changes; sort conditions netobserv-web-console#1319

Checklist

Does the changes in PR need specific configuration or environment set up for testing?

if so please describe it in PR description.

I have added thorough unit tests for the change.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-10T13:31:11Z

@jotak: This pull request references NETOBSERV-2375 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Address some old "TODOs" in status management. All statuses now follow this pattern:

They are initialized unknown

When controller found unused, status set to unused

At any point, if an error occurs, it's set with that error

Deployment/DaemonSet check progress set status either as InProgress, or Ready

New Degraded condition can be optionally set; a degraded status does not prevent it from being "ready".

Make the LokiStack status fit in this model (it was previously using an entirely different pattern)

Also, previously, in 2 different places LokiStack was fetched to get its status (for propagating status into FlowCollector status and into console plugin config) Now consolidated into a single entry point to get the loki status.

Status changes:

New status: WaitingEBPFAgents

New status: WaitingWebConsole

New status: WaitingDemoLoki

New status: WaitingLokiStack

Renamed status: WaitingFlowCollectorLegacy => WaitingFlowCollectorController

Removed: LokiIssue and LokiWarning

Dependencies

NETOBSERV-2375: adapt statuses to operator changes; sort conditions netobserv-web-console#1319

Checklist

Does the changes in PR need specific configuration or environment set up for testing?

if so please describe it in PR description.

I have added thorough unit tests for the change.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Address some old "TODOs" in status management. All statuses now follow this pattern: - They are initialized unknown - When controller found unused, status set to unused - At any point, if an error occurs, it's set with that error - Deployment/DaemonSet check progress set status either as InProgress, or Ready - New Degraded condition can be optionally set; a degraded status does not prevent it from being "ready". Make the LokiStack status fit in this model (it was previously using an entirely different pattern) Also, previously, in 2 different places LokiStack was fetched to get its status (for propagating status into FlowCollector status and into console plugin config) Now consolidated into a single entry point to get the loki status. Status changes: - New status: EBPFAgents - New status: WebConsole - New status: DemoLoki - New status: LokiStack - Renamed status: FlowCollectorLegacy => FlowCollectorController - Removed: LokiIssue and LokiWarning

jpinsonneau · 2026-03-17T11:21:49Z

 		// Set status failure unless it was already set
 		if !r.status.HasFailure() {
-			r.status.SetFailure("FlowCollectorGenericError", err.Error())
+			r.status.SetFailure("ChildReconcilerError", err.Error())


I'm not convinced by this namming but I don't know what could be better here actually 🤔

"SubReconcilerError" ? "DelegateReconcilerError" ? "DependentReconcilerError" ?

jpinsonneau

Nice work ! That will help a lot the users to have a clear view of what's going on !

Thanks @jotak

Amoghrd · 2026-03-17T15:35:06Z

/ok-to-test

github-actions · 2026-03-17T16:20:24Z

New images:

quay.io/netobserv/network-observability-operator:542cb66
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-542cb66
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-542cb66

They will expire in two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:542cb66 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-542cb66

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-542cb66
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

Amoghrd · 2026-03-17T19:22:13Z

@jotak PR looks good overall except I am not able to simulate a degraded state.

I tried high memory requests for FLP(100Gi) it showed failed.
I tried setting an incorrect nodeSelector for eBPF pods such that it does not get deployed on any node but the eBPF pod status still showed Ready with no failure which was weird too.

So let me know how do I hit the degraded state scenario

jotak · 2026-03-18T07:36:47Z

@Amoghrd the degraded condition should show up in the same conditions that previously would trigger a "LokiWarning" condition, so if you had tests previously with LokiWarning, you should be able to reuse the same. It's currently the only thing that triggers degraded.

Looking at the unit tests, an example of issue that triggers it is this one: Warning: The schema configuration does not contain the most recent schema version

I tried setting an incorrect nodeSelector for eBPF pods such that it does not get deployed on any node but the eBPF pod status still showed Ready with no failure which was weird too.

would be good to check if it's a regression of this PR; if not, we should open a bug

Amoghrd · 2026-03-18T15:36:24Z

/label qe-approved

openshift-ci-robot · 2026-03-18T15:36:34Z

@jotak: This pull request references NETOBSERV-2375 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Address some old "TODOs" in status management. All statuses now follow this pattern:

They are initialized unknown

When controller found unused, status set to unused

At any point, if an error occurs, it's set with that error

Deployment/DaemonSet check progress set status either as InProgress, or Ready

New Degraded condition can be optionally set; a degraded status does not prevent it from being "ready".

Make the LokiStack status fit in this model (it was previously using an entirely different pattern)

Also, previously, in 2 different places LokiStack was fetched to get its status (for propagating status into FlowCollector status and into console plugin config) Now consolidated into a single entry point to get the loki status.

Status changes:

New status: WaitingEBPFAgents

New status: WaitingWebConsole

New status: WaitingDemoLoki

New status: WaitingLokiStack

Renamed status: WaitingFlowCollectorLegacy => WaitingFlowCollectorController

Removed: LokiIssue and LokiWarning

Dependencies

NETOBSERV-2375: adapt statuses to operator changes; sort conditions netobserv-web-console#1319

Checklist

Does the changes in PR need specific configuration or environment set up for testing?

if so please describe it in PR description.

I have added thorough unit tests for the change.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Amoghrd · 2026-03-18T16:15:54Z

Yup the eBPF with nodeSelector bug is a regression, created a bug https://redhat.atlassian.net/browse/NETOBSERV-2674

openshift-ci-robot added the jira/valid-reference label Mar 10, 2026

jotak mentioned this pull request Mar 10, 2026

NETOBSERV-2375: adapt statuses to operator changes; sort conditions netobserv/netobserv-web-console#1319

Merged

6 tasks

jotak requested review from OlivierCazade, leandroberetta and luisjira March 10, 2026 13:39

jotak added the needs-review Tells that the PR needs a review label Mar 10, 2026

openshift-merge-robot added the needs-rebase label Mar 10, 2026

jotak added 2 commits March 10, 2026 18:05

fix flaky test

b0d7b6d

jotak force-pushed the status-refactor branch from 361713b to b0d7b6d Compare March 10, 2026 17:06

openshift-merge-robot removed the needs-rebase label Mar 10, 2026

jpinsonneau reviewed Mar 17, 2026

View reviewed changes

jpinsonneau approved these changes Mar 17, 2026

View reviewed changes

openshift-ci Bot assigned jpinsonneau Mar 17, 2026

openshift-ci Bot added the lgtm label Mar 17, 2026

jotak removed the needs-review Tells that the PR needs a review label Mar 17, 2026

openshift-ci Bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 17, 2026

Amoghrd added ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. and removed ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. labels Mar 17, 2026

openshift-ci Bot added the qe-approved QE has approved this pull request label Mar 18, 2026

jotak merged commit 8ce036a into netobserv:main Mar 18, 2026
12 of 13 checks passed

Conversation

jotak commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci-robot commented Mar 10, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci Bot commented Mar 10, 2026

Uh oh!

openshift-ci-robot commented Mar 10, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci-robot commented Mar 10, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

jpinsonneau Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

jotak Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpinsonneau left a comment

Choose a reason for hiding this comment

Uh oh!

Amoghrd commented Mar 17, 2026

Uh oh!

github-actions Bot commented Mar 17, 2026

Uh oh!

Amoghrd commented Mar 17, 2026

Uh oh!

jotak commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Amoghrd commented Mar 18, 2026

Uh oh!

openshift-ci-robot commented Mar 18, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

Uh oh!

Amoghrd commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jotak commented Mar 10, 2026 •

edited

Loading

openshift-ci-robot commented Mar 10, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 10, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 10, 2026 •

edited by openshift-ci Bot

Loading

jotak Mar 17, 2026 •

edited

Loading

jotak commented Mar 18, 2026 •

edited

Loading

openshift-ci-robot commented Mar 18, 2026 •

edited by openshift-ci Bot

Loading

Amoghrd commented Mar 18, 2026 •

edited

Loading