NETOBSERV-2388 QE Frontend tests migration by memodi · Pull Request #1317 · netobserv/netobserv-web-console

memodi · 2026-03-06T21:17:05Z

Description

NETOBSERV-2388 Migrating QE's frontend e2e tests to here

# Export required environment variables
export KUBECONFIG=/path/to/kubeconfig
export CYPRESS_LOGIN_USERS="kubeadmin:your-password"
export CYPRESS_LOGIN_IDP="kube:admin"

# Run tests
./scripts/run-e2e-tests.sh

https://gist.github.com/memodi/afc650d3d36e76e0de51c578cf835d02

Dependencies

n/a

Checklist

Does the changes in PR need specific configuration or environment set up for testing?
- if so please describe it in PR description.
I have added thorough unit tests for the change.
QE requirements (check 1 from the list):
- Standard QE validation, with pre-merge tests unless stated otherwise.
- Regression tests only (e.g. refactoring with no user-facing change).
- No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

openshift-ci · 2026-03-06T21:17:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mffiedler for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

memodi · 2026-03-09T20:32:04Z

/cc @Amoghrd @leandroberetta

scripts/run-e2e-tests.sh

Amoghrd · 2026-03-10T13:25:22Z

web/cypress/integration-tests/Readme.md

+## Tests naming
+- All tests must have all lower case in their naming to maintain alphabetical order of tests execution.
+
+## Flaky tests


I dont think this section is valid anymore? More of these tests should be less flaky now

web/cypress/views/catalog-source.ts

Amoghrd · 2026-03-10T13:31:11Z

web/cypress/views/netflow-page.ts

+    export const conversationID = '[data-test=th-_HashId] > .pf-v5-c-table__button'
+    export const flowRTT = '[data-test=th-TimeFlowRttMs] > .pf-v5-c-table__button'
+    export const dscp = '[data-test=th-Dscp] > .pf-v5-c-table__button'
+    export const DNSLatency = '[data-test=th-DNSLatency] > .pf-v5-c-table__column-help > .pf-v5-c-table__button'


These vars need to start with lower-case. Its not part of this PR scope, but will be good to have it fixed

I have updated for DNS* var names, however I'd like to contain only changes that are related to this migration work in this PR.

Amoghrd · 2026-03-10T13:33:06Z

web/cypress/views/netflow-page.ts

+    export const doubleLeftShift = backwardShift + "> div:nth-child(1) > button"
+}
+
+Cypress.Commands.add('showAdvancedOptions', () => {


I think some of the commands added here were taken from the console repo. So there might be repetition and can be removed

any idea which commands are repeated? for e.g.: I only see showAdvancedOptions defined here in this file, no where else.

I see repeated funcs in here

pushed commit to remove duplicate cypress commands, I have kept checkPopupItems and changeQueryOption since those have different implementations.

Dockerfile.e2e

Amoghrd · 2026-03-10T13:44:22Z

@memodi thanks! Couple of questions:

How are we going to handle different selectors in older OCP versions?
Just to confirm if the answer to the first question is that these tests are run only on latest OCP versions, then are we going to still use openshift-tests-private repo for running the tests?
There are about 6 failing tests in the gist pasted above. AFAIK all tests should be passing so is there some issue in the test or is it due to migration?
Are all the funcs ported over in the views files used? Just wanted to confirm if the whole file was ported over or only the funcs used by NetObserv

memodi · 2026-03-10T14:20:52Z

@Amoghrd:

How are we going to handle different selectors in older OCP versions?

We'll need to branches based on OCP versions here in web-console repo.

Just to confirm if the answer to the first question is that these tests are run only on latest OCP versions, then are we going to still use openshift-tests-private repo for running the tests?

No, once this is merged, I'll create branches and make adjustments to tests/libs for older version in their PRs.

There are about 6 failing tests in the gist pasted above. AFAIK all tests should be passing so is there some issue in the test or is it due to migration?

I expect some flakes with UI tests, but that shouldn't block the migration. I'll continue to fix the tests during this PR and even after.

Are all the funcs ported over in the views files used? Just wanted to confirm if the whole file was ported over or only the funcs used by NetObserv

I've tried to minimize the code which we're not using from openshift-tests-private, but it's possible some extra stuff may have trickled in since functions could call other functions in the same file.

memodi · 2026-03-10T14:23:47Z

web/cypress/integration-tests/env.cy.ts

this file needs to be removed from PR.

Amoghrd · 2026-03-10T14:24:17Z

One other question I forgot to ask, will this script replace the qe-e2e-console-tests check on PRs once its merged?

memodi · 2026-03-10T14:26:40Z

One other question I forgot to ask, will this script replace the qe-e2e-console-tests check on PRs once its merged?

Not immediately, but eventually all the CI will need updating and new pipelines will need to be created.

jotak · 2026-03-10T17:16:46Z

.gitignore

+/web/src/**/*.js
+/web/src/**/*.spec.js


why excluding js sources ? Although we probably don't have any, no js file should be generated in the web/src , or is it not correct?

I have lot of js files locally from past build commands I had ran, don't you get those js artifacts when building locally?

weird, no, I never have that ... Maybe old stuff ?

jotak · 2026-03-10T17:22:26Z

web/tsconfig.json

    "esModuleInterop": true,
    "resolveJsonModule": true,
-    "baseUrl": ".",
+    "types": [


This would restrict a lot the dependency types available, is that something really needed?
Also the exclusion list below reduces the type checking coverage.
If a different tsconfig is needed for e2e tests we can perhaps create another one, rather than changing the main .one

done, there's tsconfig.json for e2e tests I removed these from here.

openshift-ci · 2026-03-10T21:06:42Z

@memodi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/qe-e2e-console-tests	`f14b03f`	link	false	`/test qe-e2e-console-tests`
ci/prow/images	`f14b03f`	link	true	`/test images`
ci/prow/plugin-cypress	`f14b03f`	link	true	`/test plugin-cypress`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

memodi force-pushed the qe-tests-migration branch from ab2a6c5 to 9404ea3 Compare March 6, 2026 21:19

memodi requested review from jotak, jpinsonneau and oliver-smakal March 9, 2026 20:31

openshift-ci bot requested review from Amoghrd and leandroberetta March 9, 2026 20:32

Amoghrd reviewed Mar 10, 2026

View reviewed changes

scripts/run-e2e-tests.sh Outdated Show resolved Hide resolved

Amoghrd reviewed Mar 10, 2026

View reviewed changes

web/cypress/views/catalog-source.ts Outdated Show resolved Hide resolved

Amoghrd reviewed Mar 10, 2026

View reviewed changes

Dockerfile.e2e Outdated Show resolved Hide resolved

memodi commented Mar 10, 2026

View reviewed changes

web/cypress/integration-tests/env.cy.ts

Copy link

Member Author

memodi Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file needs to be removed from PR.

jotak reviewed Mar 10, 2026

View reviewed changes

migrating frontend integration tests to upstream

de1ef81

memodi force-pushed the qe-tests-migration branch from 9404ea3 to de1ef81 Compare March 10, 2026 19:28

memodi added 2 commits March 10, 2026 15:51

review comments

e81f905

remove duplicate cypress custom commands

f14b03f

		/web/src/*/.js
		/web/src/*/.spec.js

Conversation

memodi commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci bot commented Mar 6, 2026

Uh oh!

memodi commented Mar 9, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Amoghrd commented Mar 10, 2026

Uh oh!

memodi commented Mar 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Amoghrd commented Mar 10, 2026

Uh oh!

memodi commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

memodi commented Mar 6, 2026 •

edited

Loading

memodi commented Mar 10, 2026 •

edited

Loading