Skip to content

Documentation update, health rules polishing#2389

Merged
jotak merged 4 commits intonetobserv:mainfrom
jotak:doc-update
Feb 2, 2026
Merged

Documentation update, health rules polishing#2389
jotak merged 4 commits intonetobserv:mainfrom
jotak:doc-update

Conversation

@jotak
Copy link
Member

@jotak jotak commented Jan 29, 2026

Description

@jotak jotak requested a review from gwynnemonahan January 29, 2026 09:13
@jotak
Copy link
Member Author

jotak commented Jan 29, 2026

@gwynnemonahan , for the downstream doc, here's the key things:

Copy link
Contributor

@leandroberetta leandroberetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jotak added 4 commits January 29, 2026 14:29
- Rename IngressLatencyTrend => IngressHTTPLatencyTrend to distinguish
  with our other TCP latency
- Mark InstallDemoLoki as Unsupported
- Rename Alerts.md => HealthRules.md, and refresh its content; link to
  runbooks for details
@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2026

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.05%. Comparing base (5b9cf16) to head (ec31385).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/metrics/alerts/alerts.go 33.33% 2 Missing ⚠️
...lector/v1beta2/flowcollector_validation_webhook.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2389      +/-   ##
==========================================
+ Coverage   72.01%   72.05%   +0.04%     
==========================================
  Files          93       93              
  Lines       10501    10501              
==========================================
+ Hits         7562     7567       +5     
+ Misses       2464     2460       -4     
+ Partials      475      474       -1     
Flag Coverage Δ
unittests 72.05% <62.50%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...flowcollector/v1beta2/flowcollector_alert_types.go 97.59% <100.00%> (ø)
api/flowcollector/v1beta2/flowcollector_types.go 100.00% <ø> (ø)
internal/pkg/metrics/alerts/builder.go 78.40% <100.00%> (ø)
...lector/v1beta2/flowcollector_validation_webhook.go 72.29% <50.00%> (ø)
internal/pkg/metrics/alerts/alerts.go 87.05% <33.33%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotak jotak merged commit b15953e into netobserv:main Feb 2, 2026
14 of 15 checks passed
@jotak
Copy link
Member Author

jotak commented Feb 2, 2026

/cherry-pick release-1.11

@openshift-cherrypick-robot

@jotak: new pull request created: #2400

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants