Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Fixed an error in converting foreign key values to integers #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dohnal
Copy link

@dohnal dohnal commented Jun 17, 2017

  • bug fix? yes
  • new feature? no
  • BC break? yes/no
  • doc PR: nette/docs#???

An issue of auto-convert of row values used as foreign keys to integers (by PHP). The values were used in cacheKeys as array keys, so they got converted by PHP. It is clearly wrong. This request changes the storage of row values to array values.

@dg
Copy link
Member

dg commented Jun 19, 2017

It seems that it breaks tests.

ping @dohnal

@dg dg force-pushed the master branch 4 times, most recently from abe9849 to 9358712 Compare June 29, 2017 15:38
@dg dg force-pushed the master branch 7 times, most recently from f1a9aa2 to ec7a207 Compare July 26, 2017 21:39
@dg dg force-pushed the master branch 14 times, most recently from 1ea2fe2 to f4d7fc0 Compare March 23, 2018 16:52
@dg dg force-pushed the master branch 26 times, most recently from a329d1b to 9f82d9d Compare September 5, 2024 02:37
@dg dg force-pushed the master branch 2 times, most recently from 1769a67 to b02f117 Compare January 9, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants