Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco ios show ip bgp summary #1442

Conversation

PavloSkliarenko
Copy link
Contributor

@PavloSkliarenko PavloSkliarenko commented Aug 14, 2023

I`m kinda new to Github. So I don`t realy sure about: is my new commits are visible in PR after your change request. So I closed my previous PR and opened this one

@mjbear
Copy link
Contributor

mjbear commented Aug 15, 2023

Hello @PavloSkliarenko,

Yes, your changes/diffs can be found on the Files Changed tab near the top of the PR.
https://github.com/networktocode/ntc-templates/pull/1442/files

@PavloSkliarenko
Copy link
Contributor Author

@jvanderaa Take a look at this fix, please. I`ve added new values and fixed the names of old ones to be more understandable

@mjbear
Copy link
Contributor

mjbear commented Dec 28, 2023

@PavloSkliarenko
I'm just a community member, but I'd like to thank you for your contributions.

Edit: Breaking changes like these generally are merged gradually as Network to Code prepares to pin a new release.

There is an "unofficial" effort to normalize "common" capture group names across templates of similar uses (for all vendors). Although the PR #1468 hasn't been merged into the mainline yet, there is a document I hope to keep up-to-date (which with your changes here needs updates) and make these updates across all vendors' templates where appropriate.

Maybe it's possible to brainstorm some standard capture group names for common ones. Sound like something you're interested in?

I too plan to bug @jvanderaa and @itdependsnetworks a bit to see that this documentation PR makes it to mainline sooner than later so each template contribution not only has documentation but should also comply with established "standard" capture group names. 😄

@jvanderaa
Copy link
Contributor

This looks good. I will plan to get a new major release out in the next 2 weeks or less.

@pszulczewski pszulczewski merged commit de85102 into networktocode:master Apr 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants