Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1577 so junos logical interface link status and mtu are captured #1593

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Jan 13, 2024

Fix juniper_junos_show_interfaces template for issue #1577 and other minor enhancements

Notes:

  • logical interfaces have no data for admin_state so it is an empty string
  • logical interfaces have no data for hardware_type so it is an empty string

@andyb2000
Copy link

Tested on my environment here and confirm this is working as expected. Parsed output:

{'admin_state': '',
  'description': 'Customer: interface:',
  'destination': 'x.x.x.x/29',
  'hardware_type': '',
  'interface': 'irb.6027',
  'link_status': 'Up',
  'local': 'x.x.x.y',
  'mtu': '1514'},

@mjbear
Copy link
Contributor Author

mjbear commented Jan 18, 2024

Tested on my environment here and confirm this is working as expected. Parsed output:

{'admin_state': '',
  'description': 'Customer: interface:',
  'destination': 'x.x.x.x/29',
  'hardware_type': '',
  'interface': 'irb.6027',
  'link_status': 'Up',
  'local': 'x.x.x.y',
  'mtu': '1514'},

@jvanderaa
There's additional confirmation beyond unit tests that this fix works. Thank you for reviewing and merging this in!

@jvanderaa jvanderaa merged commit 768ebcc into networktocode:master Feb 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants