Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize vlan id and name stragglers #1984

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Normalize vlan id and name stragglers #1984

wants to merge 8 commits into from

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Jan 19, 2025 •
edited
Loading

⚠️ Breaking change ⚠️
🎯 This builds upon PR #1983 (which converts lowercase capture groups to uppercase).

Since these capture groups were lowercase (until PR #1983), they likely didn't get normalized during PR #1416

  • ntc_templates/templates/cisco_ios_show_ip_dhcp_snooping_binding.textfsm
    • VLAN -> VLAN_ID
    • simplify VLAN_ID regex
  • ntc_templates/templates/cisco_s300_show_interfaces_switchport.textfsm
    • and
  • ntc_templates/templates/eltex_show_interfaces_switchport.textfsm
    • VLAN -> VLAN_ID
    • NAME -> VLAN_NAME
  • ntc_templates/templates/huawei_smartax_display_mac-address_ont_0_1_2_0.textfsm
    • VLAN -> VLAN_ID
  • ntc_templates/templates/extreme_exos_show_iparp.textfsm
    • VLAN -> VLAN_NAME
    • VID -> VLAN_ID

@mjbear mjbear force-pushed the normalize_vlan_id_and_name_stragglers branch from 1a2be08 to 64f27e7 Compare January 31, 2025 22:27
@mjbear mjbear mentioned this pull request Feb 7, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks will be requested when the pull request is marked ready for review itdependsnetworks is a code owner

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 will be requested when the pull request is marked ready for review jmcgill298 is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa will be requested when the pull request is marked ready for review jvanderaa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mjbear