Adding new template for Huawei SmartAX: display location <mac>
#1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilmonkey19
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
mjbear
reviewed
Jan 27, 2025
ntc_templates/templates/huawei_smartax_display_location_aaaa-aaaa-aaaa.textfsm
Outdated
Show resolved
Hide resolved
…aaa-aaaa.textfsm I take note! Commiting 🚀 Co-authored-by: Michael Bear <[email protected]>
jvanderaa
reviewed
Feb 11, 2025
| @@ -674,6 +674,7 @@ huawei_smartax_display_ont_info_0_1_2.textfsm:huawei_smartax_display_ont_info_de | |||
| huawei_smartax_display_ont_port_vlan_0_1_byport_eth_0.textfsm, .*, huawei_smartax, di[[splay]] ont p[[ort]] vl[[an]] \d+ \d+ byport eth \d+\s* | |||
| huawei_smartax_display_ont_port_state_0_1_eth-port.textfsm, .*, huawei_smartax, di[[splay]] on[[t]] por[[t]] st[[ate]] \d+ \d+ e[[th-port]] | |||
| huawei_smartax_display_ont_port_vlan_0_1_byvlan_0.textfsm, .*, huawei_smartax, di[[splay]] ont p[[ort]] v[[lan]] \d+ \d+ byvlan \d+ | |||
| huawei_smartax_display_location_aaaa-aaaa-aaaa.textfsm, .*, huawei_smartax, disp[[lay]] loc[[ation]] \S+\s*$ | |||
There was a problem hiding this comment.
Suggested change
| huawei_smartax_display_location_aaaa-aaaa-aaaa.textfsm, .*, huawei_smartax, disp[[lay]] loc[[ation]] \S+\s*$ | |
| huawei_smartax_display_location.textfsm, .*, huawei_smartax, disp[[lay]] loc[[ation]] \S+\s*$ |
There was a problem hiding this comment.
I believe that we want to keep it at the short end of the command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the command look similar to #1993 it is not as the end result is different. Take care because this command comes doesn't add the
ontand the output different.