Hp comware display interface fix #2007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar interface that has (Cellular-Allocated) instead of P/primary, as well as ignore the field Transfer time that is unique for said interface
CursedEnvy
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
|
Heads up to maintainers that this could cause merge conflicts with #1963 since they're changes to the same templates. (Not the end of the world, just something that will need sorted and smoothed out. 😅) |
…X for this one (release 09119P17) And of course some new lines are there and a small difference for another. Renamed my other test-file and added one for this release too.
mjbear
reviewed
Feb 5, 2025
mjbear
reviewed
Feb 5, 2025
Accepting regex improvement from mjbear Co-authored-by: Michael Bear <[email protected]>
Accepting regex improvement from mjbear Co-authored-by: Michael Bear <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently in the past we used cellular sics in our hp comware router, which leads to a difference in output for display interface when it comes to the template currently as is.
This small change to the regex should cover both routers without this interface, as is as well as our old setups where we have a cellular interface.
There is also a line about transfer time present, but this seems rather unimportant so I added it to the drop part
I added an example raw file, made the yaml and ran the tests successfully.
Hope this suffices