fix: It seems all templates are based upon hp comware switches

[CursedEnvy]

It seems all templates are based upon hp comware switches and not hp comware routers, there are some subtle differences in the outputs.
I do not know if it would be preferable to make separate templates or try to align both outputs into one template?
It seems there's enough overlap to warrant the last option, but else I am open to split them up.
We use the HP Comware MSR 2003/2003X/3012 and 958X routers for reference.

[mjbear]

It seems all templates are based upon hp comware switches and not hp comware routers, there are some subtle differences in the outputs. I do not know if it would be preferable to make separate templates or try to align both outputs into one template?

This project generally(?) uses the platform values Netmiko has set forth.

Not only is there only a single hp_comware platform, your other point below is a bigger reason to have a single template.

It seems there's enough overlap to warrant the last option, but else I am open to split them up. We use the HP Comware MSR 2003/2003X/3012 and 958X routers for reference.

Since there's some overlap it is best to integrate them into a single template.
Test data is going to be important and ideally name the test data files so we can tell they're your routers. 😉

Update: Oh and I didn't look and mistakenly thought this was an issue ticket. Oooops.

[CursedEnvy]

It seems all templates are based upon hp comware switches and not hp comware routers, there are some subtle differences in the outputs. I do not know if it would be preferable to make separate templates or try to align both outputs into one template?

This project generally(?) uses the platform values Netmiko has set forth.

Not only is there only a single hp_comware platform, your other point below is a bigger reason to have a single template.

It seems there's enough overlap to warrant the last option, but else I am open to split them up. We use the HP Comware MSR 2003/2003X/3012 and 958X routers for reference.

Since there's some overlap it is best to integrate them into a single template. Test data is going to be important and ideally name the test data files so we can tell they're your routers. 😉

Update: Oh and I didn't look and mistakenly thought this was an issue ticket. Oooops.

Okay all good, I was maybe thinking too much forward that my changes might get too convoluted.

I appended the firmware version at the end of the two test files I added, is that okay? MSR2003/3012 share older versions, if you want I can search and try all the ones we have in the field, while MSR958X and MSR2003X have the their own separate firmware versions and are rather new models we place at the moment. Or do you guys prefer the router names in the files instead.

And sorry, I try to do semantic commit messages as recommended by a colleague, sorry if that made you think it was an issue, I can leave that out if you prefer.

[mjbear]

I appended the firmware version at the end of the two test files I added, is that okay? MSR2003/3012 share older versions, if you want I can search and try all the ones we have in the field, while MSR958X and MSR2003X have the their own separate firmware versions and are rather new models we place at the moment. Or do you guys prefer the router names in the files instead.

What you've got works.

And sorry, I try to do semantic commit messages as recommended by a colleague, sorry if that made you think it was an issue, I can leave that out if you prefer.

I figured it out, haha. 😅