Add hp_comware_display_bgp_peer_ipv4 #2020
Conversation
…uter (it is also possible to use vprn-instance {instance_name} after the commando, output is the same (except for the neighbours of course))
Test file is the data as shown on a router (when I use my script to read out the config, the new line and spaces before BGP local router are gone, hence the use of * to cover this)
I choose to Filldown the top variables, because I noticed this was the case on the IOS template as well
CursedEnvy
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
ntc_templates/templates/hp_comware_display_bgp_peer_ipv4.textfsm
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,26 @@ | |||
| Value Filldown LOCAL_ROUTER_ID (\d{1,3}(?:\.\d{1,3}){3}) | |||
| Value Filldown LOCAL_AS_NUMBER (\d+) | |||
| Value Filldown TOTAL_PEERS (\d+) | |||
There was a problem hiding this comment.
Edited:
Does it make sense to capture the Total Peers count?
(We'd already know how many peers based on the length of the list that is returned.)
There was a problem hiding this comment.
Coincidentally had an discussion on that with my colleague yesterday, in the end I looked at some ios show ip bgp templates and saw them do this, but I still agree it felt weird and indeed now that you mention it, redundant. He was also in favour of leaving it out.
Only thing I now start to wonder is how will this handle multiple AS neighbours, maybe I'll have to search a test case today.
There was a problem hiding this comment.
Update: actually don't think we have such a case of multiple AS neighbours anywhere or at least I'll be searching a needle in a haystack
Anyway, I removed the total and established peers!
| Value Filldown LOCAL_ROUTER_ID (\d{1,3}(?:\.\d{1,3}){3}) | ||
| Value Filldown LOCAL_AS_NUMBER (\d+) | ||
| Value Filldown TOTAL_PEERS (\d+) | ||
| Value Filldown PEERS_ESTABLISHED (\d+) |
There was a problem hiding this comment.
Similar to Total Peers count, is the Established Peer count important since the State is already being captured?
There was a problem hiding this comment.
I agree, can be left out and handled for example with a property if you turn the dict into a basemodel later.
|
@CursedEnvy |
Accepting mjbear his change to make the AS variable more descriptive Co-authored-by: Michael Bear <[email protected]>
Sure, thank you for your input always, I am happy to hear your thoughts! |
ntc_templates/templates/hp_comware_display_bgp_peer_ipv4.textfsm
Outdated
Show resolved
Hide resolved
Accepting improvement to leave out state transition from mjbear Co-authored-by: Michael Bear <[email protected]>
Adding a template to read out the bgp ipv4 neighbours on a comware router
(it is also possible to use vprn-instance {instance_name} after the commando, output is the same (except for the neighbours of course))
Test file is the data as shown on a router (when I use my script to read out the config, the new line and spaces before BGP local router are gone, hence the use of * to cover this)
I choose to Filldown the top variables, because I noticed this was the case on the IOS template as well
Had to get a lot of help from a colleague as my first steps creating something from nothing, I am not good at regex, yet :)