Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add scripts for kubernetes dev env using vLLM and vLLM-p2p #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat: Add scripts for kubernetes dev env using vLLM and vLLM-p2p #60
Changes from all commits
a80c163
1a7fa8e
f5bc959
bee5fa9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this depend on VLLM_MODE?
Will the Pods come up if
HF_SECRET_*
are not defined (e.g., when using simulator)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For VLLM-SIM, it’s not needed, so I generate a dummy key in the script (you don’t need to define it).
My issue is that I separated the gateway creation from the vLLM creation - I think it’s cleaner this way.
This is the only dependency we have, so I don’t mind if all versions of EPP receive all the variables and choose whether to use them or not.