-
Notifications
You must be signed in to change notification settings - Fork 32
Add docs for data/datasets and how to configure them in GuideLLM #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Build artifacts (.whl and .tar.gz) are available for download for up to 30 days. |
Build artifacts (.whl and .tar.gz) are available for download for up to 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new documentation page for configuring data and datasets in GuideLLM, and updates the README to include a link to the new guide.
- Introduces detailed guidance on dataset configurations, examples, and usage.
- Updates the main README to reference the new Data/Datasets Guide.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
docs/datasets.md | New documentation outlining dataset configuration and usage. |
README.md | Updated navigation to include the new Data/Datasets guide. |
Co-authored-by: Copilot <[email protected]>
Build artifacts (.whl and .tar.gz) are available for download for up to 30 days. |
@markurtz Thank you very much for this, this simplifies and makes things much clearer. 2 small comments from my end:
|
@SharonGil take a look through again now, I've updated based on this feedback to make the points you raised clearer and try and answer your questions |
Build artifacts (.whl and .tar.gz) are available for download for up to 30 days. |
@markurtz That's perfect. Thanks a lot for the clarifications! |
Fixes #133