Skip to content

Add container build jobs to all build workflows #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sjmonson
Copy link
Collaborator

@sjmonson sjmonson commented Jun 17, 2025

Add container build jobs alongside the existing wheel jobs. Tag containers based on which workflow was triggered.

Tags:

  • PR: pr-{{ github.event.number }} {{ github.sha }}
  • Nightly: nightly {{ github.sha }}
  • Release candidate: latest {{ github.sha }}
  • Release: latest stable {{ github.sha }}

Edit: To save space, don't use unique tags.


Future Improvements (Follow up PR)

  • Tag RC and releases with their versions. (e.g. 0.3.0-rc, 0.3.0)
  • Reuse wheel builds in container

@sjmonson sjmonson force-pushed the feat/container_ci branch from cd53d14 to 9f72b0f Compare June 17, 2025 20:10

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15717009161/artifacts/3348790000.
They will be retained for up to 30 days.

@sjmonson sjmonson force-pushed the feat/container_ci branch from 9f72b0f to 7f29432 Compare June 17, 2025 20:16

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15717125485/artifacts/3348834899.
They will be retained for up to 30 days.

@sjmonson sjmonson force-pushed the feat/container_ci branch from 7f29432 to fc1b3b2 Compare June 17, 2025 20:23
@sjmonson sjmonson changed the title WIP: Add container build jobs to all build workflows Add container build jobs to all build workflows Jun 17, 2025
@sjmonson sjmonson force-pushed the feat/container_ci branch from fc1b3b2 to 9b3e87c Compare June 17, 2025 20:28

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15717342057/artifacts/3348916151.
They will be retained for up to 30 days.

@sjmonson sjmonson changed the title Add container build jobs to all build workflows WIP: Add container build jobs to all build workflows Jun 17, 2025
@sjmonson sjmonson force-pushed the feat/container_ci branch from 9b3e87c to 23f64b9 Compare June 20, 2025 19:38

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15786504984/artifacts/3372647289.
They will be retained for up to 30 days.

@sjmonson sjmonson force-pushed the feat/container_ci branch from 23f64b9 to 0bbaf03 Compare June 20, 2025 19:46

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15786624113/artifacts/3372696623.
They will be retained for up to 30 days.

@sjmonson sjmonson changed the title WIP: Add container build jobs to all build workflows Add container build jobs to all build workflows Jun 27, 2025
@sjmonson sjmonson requested review from Copilot and markurtz June 27, 2025 20:43
Copilot

This comment was marked as outdated.

@sjmonson sjmonson requested a review from Copilot June 27, 2025 20:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds container build jobs to the existing build workflows, enabling container image builds and pushes alongside the wheel builds.

  • Added a new job "build-and-push-container" in the release, release-candidate, nightly, and development workflows.
  • Configured different container image tag strategies based on the workflow context.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yml Introduces container build and push job with tags "latest stable".
.github/workflows/release-candidate.yml Adds container build step with tag "latest".
.github/workflows/nightly.yml Implements a container job with the "nightly" tag.
.github/workflows/development.yml Creates a container build job using a PR-based tag.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15935649149/artifacts/3422329368.
They will be retained for up to 30 days.

@sjmonson sjmonson self-assigned this Jun 27, 2025
@sjmonson sjmonson force-pushed the feat/container_ci branch from 2776f6c to f0ebe02 Compare June 27, 2025 20:52

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15935744694/artifacts/3422360640.
They will be retained for up to 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant