Skip to content

Conversation

JoeZiminski
Copy link
Member

Currently AWS or GDrive tests fail when run locally if environment variables required for set up are not set. Now, these tests are just skipped.

Copy link
Collaborator

@cs7-shrey cs7-shrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JoeZiminski, we have similar tests in tests_tui as well for gdrive and aws connection setup. So, I was wondering if we can move the has_variables... function logic to test_utils.py and then skip those TUI tests as well.

@JoeZiminski
Copy link
Member Author

Thanks @cs7-shrey I forgot about those! I did a small refactor to include these in the transfer tests. Even though it's a bit strange to have TUI tests outside of tests_tui and with transfers, it makes it less likely to forget that these config tests also use the connection set up machinery in future. On balance I think that is slightly preferable.

Copy link
Collaborator

@cs7-shrey cs7-shrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we can remove the directoriestests_tui/aws and tests_tui/gdrive.

@JoeZiminski
Copy link
Member Author

Thanks Shrey, locally I have them deleted but I can see one is still there on the github repo 🤔 sometimes git doesn't handle empty folders properly, I'll merge and hope it disappears. Thanks!

Also just a general note on this PR, the SonarCloud is failing for a code-duplication reason that is actually acceptable and wanted, so not addressing.

@JoeZiminski JoeZiminski merged commit aebbb5c into main Sep 8, 2025
15 of 16 checks passed
@JoeZiminski JoeZiminski deleted the skip_aws_gdrive_tests branch September 8, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants