Add more suggest next sub ses tests #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeZiminski
force-pushed
the
add_more_suggest_next_sub_ses_tests
branch
from
59a60ff to
8bb347a
Compare
cs7-shrey
requested changes
Sep 30, 2025
There was a problem hiding this comment.
This looks good @JoeZiminski. I just have some refactoring suggestions.
JoeZiminski
force-pushed
the
add_more_suggest_next_sub_ses_tests
branch
from
92df081 to
8fbd450
Compare
JoeZiminski
force-pushed
the
add_more_suggest_next_sub_ses_tests
branch
from
8fbd450 to
c531bb8
Compare
cs7-shrey
reviewed
Oct 10, 2025
Co-authored-by: Shrey Singh <[email protected]>
Co-authored-by: Shrey Singh <[email protected]>
|
Thanks @cs7-shrey! Apologies, they were very basic errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug for suggest next sub / ses through the TUI, which was not triggered in
central_onlymode for AWS and GDrive. Tests are added to cover suggest next sub / ses in SSH, AWS and GDrive, this is a little redundant as the use the same method under the good for central file searches, but it can't hurt at this early stage in deployment. No other tests or documentation is required.