Pin fancylog. #641
Pin fancylog. #641
Conversation
pyproject.toml
Outdated
| "fancylog >= 0.7.0; python_version >= '3.11'", | ||
| "fancylog < 5; python_version < '3.11'", |
There was a problem hiding this comment.
Why <5 when we're on 0.7.0? Why not just make it >0.7.0 across all python versions?
There was a problem hiding this comment.
I thought I saw that the dependency resolver failed and installed older versions of fancylog for old versions of python. But I think I might have made this up 🤔 will do a quick check now
There was a problem hiding this comment.
By why <5 when we haven't even released v1? 🤣
There was a problem hiding this comment.
I didn't even notice that 😂 it should be 0.5.0, I think it still worked because fancylog 0.5.0 doesn't support python 3.9 or 3.10 (?, just checking) and so it installs <0.5.0 on these runners and is fine.
|
FYI I raised neuroinformatics-unit/fancylog#86 so we can track fancylog supporting datashuttle properly across Python versions. |
Further to #635 this PR pins fancylog to avoid the release in which package versions was logged by default, that included a subprocess call. This slowed down tests a lot. Tests are now running at their usual duration.
TODO: reverse CI changes before merging