-
Notifications
You must be signed in to change notification settings - Fork 72
BrainGlobe : Adding to Brainglobe's data visualisation tools (Pranav Kapoor) #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamltyson Could you please provide feedback here sir also ?
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pranav33317, please see my in-line comments. There seems to be considerable overlap between your applications. I suggest you focus on one application at this stage and take care to write a well thought out proposal, specific to that project. Please also make sure that your time commitments make sense.
Please note at this stage, we're not able to offer any further feedback. Good luck!
GSoC-2025/application_template.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert all changes to this file?
GSoC-2025/pranav_kapoor.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rename this file according to the template (although without colons, that's our mistake!)?
GSoC-2025/pranav_kapoor.md
Outdated
- PR: [Disable parallel mesh creation (PR #546)](https://github.com/brainglobe/brainglobe-atlasapi/pull/546#pullrequestreview-2729541724) | ||
(I worked on disabling parallel mesh creation in various files while addressing [Issue #429](https://github.com/brainglobe/brainglobe-atlasapi/issues/429).) | ||
- **Proposal discussion link:** | ||
- [Proposal Discussion (PR #554)](https://github.com/brainglobe/brainglobe-atlasapi/pull/554) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see your other PR.
This should be a link to the discussion about your proposed project, i.e. this PR.
GSoC-2025/pranav_kapoor.md
Outdated
## Project proposal | ||
|
||
### Synopsis | ||
The BrainGlobe brainrender tool is a widely used resource for visualizing brain data within a common coordinate framework defined by a “brain atlas.” However, its command-line interface makes it inaccessible to many researchers who lack programming expertise. The brainrender‑napari tool seeks to change this by bringing brainrender’s powerful visualization capabilities into napari—a popular open-source graphical image viewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brainrender doesn't have a CLI, it's a Python API.
GSoC-2025/pranav_kapoor.md
Outdated
- Extend support for additional species or imaging modalities. | ||
- Integrate schema validation using tools like `jsonschema` to ensure compliance with data standards. | ||
- Develop a conversion utility to update existing atlas packages to the new standard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copied from your other proposal and not relevant here.
GSoC-2025/pranav_kapoor.md
Outdated
|----------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------| | ||
| 1–2 | **Community Bonding & Research:**<br>- Deeply explore the BrainGlobe brainrender and brainrender‑napari codebases.<br>- Study publicly available atlas‑registered data for mouse and fish brains.<br>- Engage with mentors and set up a focused development environment. | 30 | | ||
| 3–4 | **Design & Planning:**<br>- Map the current atlas data to a format suitable for brainrender‑napari.<br>- Design a modular napari widget with wireframes for the download and visualization workflow.<br>- Outline minimal deliverables and document initial design decisions. | 30 | | ||
| 5–6 | **Core Development – Part 1:**<br>- Implement the new widget and its supporting data download module.<br>- Integrate basic visualization capabilities using brainrender functions within napari.<br>- Adapt the Allen Human atlas packaging script to test the new workflow. | 30 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of this is copied from your other proposal and not relevant here.
GSoC-2025/pranav_kapoor.md
Outdated
|
||
### Implementation timeline | ||
|
||
I plan to commit 30–35 hours per week toward this project. Below is my detailed 12‑week timeline: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below you said 15 hours.
Sir I have made the changes you described, sorry for the time irregularities, have fixed them. |
Hey, as with #44, there is still an edit to the application template (which reverts another PR), could you remove this file from the PR? |
Hi @pranav33317, if this proposal was submitted to GSoC, would you mind cleaning it up so we can merge it into the repository. In particular:
Thanks, and we hope you consider contributing further to open source! |
Sir I chose to focus on a single project and focus on that proposal only , so didn't submit a proposal for this . Will close the PR now . |
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
My proposal for GSOC 2025
What does this PR do?
References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the
documentation has been updated.
Checklist: