Repository navigation
Conversation
Record the decided design of #415: format classes hold a header record and a raw data object instead of inheriting a stateful parser, with metadata, dispatcher and format layers, cached data views, write precedence, the public surface, the relation to the #233 metadata memo, the implementation passes, the conformance checks and the open tensions found so far. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
Contributor
Author
|
The same failure came back on the one re-run. Nothing in this PR can fix it, since it only adds a Markdown file. The same check passed on main at 77e0807 a few hours ago, and Generated by Claude Code |
Add the tensions and workarounds found while implementing pass 1a to the design note. Mark the ones that pass 1a resolves and fold the duplicates into the existing entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
Add the tensions, decisions and workarounds found while implementing pass 1b, the NIfTI image, to the design note, and fold the duplicates into the existing entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
This was referenced Oct 10, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
#415) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
This was referenced Oct 10, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
docs/design/format-records.md, the design note for #415. Format classes hold a record of their file instead of inheriting a parser. The note also covers how the record relates to the format metadata of #233.It records the design decided in #415:
Metadata,Image,Transformation);MetadataFormat,ImageFormat,TransformationFormat);<X>Metadataholding the<X>Rawheader record;<X>Image/<X>Transformationholding<X>Metadataand arawdata object.rawis the only stored array, anddatais a cached view decoded from it by exact, invertibleto_model/to_diskpairs.RawandMetadataclasses are public, proxies are private.This is a living document. Its last section, "Open tensions and workarounds", is updated as the implementation PRs find problems, edge cases and workarounds. The implementation goes in stacked PRs, starting with the core (pass 1a) and NIfTI.
Documentation only.
ruff check,ruff format --checkand codespell are clean.Refs #415, #233
🤖 Generated with Claude Code
https://claude.ai/code/session_01M3KmPTJ2CihFMCFaJ4twx8
Generated by Claude Code