Integrating Metrics Forwarder with Log forwarder #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrai-nr
changed the title
maya-jha
requested changes
May 12, 2025
Contributor
maya-jha
left a comment
maya-jha
left a comment
There was a problem hiding this comment.
Will E2E test fail after these changes assuming publishing for metrics forwarder is done.
maya-jha
reviewed
May 12, 2025
maya-jha
previously approved these changes
May 12, 2025
Contributor
Author
No, E2E test won't fail if the metrics forwarder is published. |
maya-jha
approved these changes
Jul 8, 2025
Contributor
|
We should find a way to merge these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
Testing done:
The code was tested by using a dummy workflow and outputting the template file using
cat command.