Skip to content

[NR-475488] enable retention period for log groups #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahegdeNR wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[NR-475488] enable retention period for log groups #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5159e19
added log groups retention period
ahegdeNR Oct 16, 2025
152c965
modified conditions for log groups
ahegdeNR Oct 16, 2025
2813b77
fixes
ahegdeNR Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lambda-cloudwatch-trigger-stack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,4 +192,12 @@ Resources:
Handler: index.lambda_handler
Role: !GetAtt NewRelicLogsCloudWatchLambdaIAMRole.Arn
Runtime: python3.12
Timeout: 120
Timeout: 120

NewRelicLogsCloudWatchLambdaLogGroup:
Type: AWS::Logs::LogGroup
DeletionPolicy: Delete
Condition: HasValidLogGroups
Properties:
RetentionInDays: 14
LogGroupName: !Sub "/aws/lambda/${NewRelicLogsCloudWatchLambda}"
30 changes: 30 additions & 0 deletions lambda-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,14 @@ Resources:
Runtime: python3.12
Timeout: 120

NewRelicLogsAttributeValidationLambdaLogGroup:
Type: AWS::Logs::LogGroup
DeletionPolicy: Delete
Condition: IsCommonAttributesNotBlank
Properties:
RetentionInDays: 14
LogGroupName: !Sub "/aws/lambda/${NewRelicLogsAttributeValidationLambda}"

NewRelicLogsResourceForAttributeValidation:
Type: AWS::CloudFormation::CustomResource
Condition: IsCommonAttributesNotBlank
Expand Down Expand Up @@ -176,6 +184,12 @@ Resources:
- secretsmanager:DescribeSecret
Resource: !Sub 'arn:aws:secretsmanager:${AWS::Region}:${AWS::AccountId}:secret:*'

NewRelicLogsServerlessLogForwarderLogGroup:
Type: AWS::Logs::LogGroup
DeletionPolicy: Delete
Properties:
LogGroupName: !Sub "/aws/lambda/${NewRelicLogsServerlessLogForwarder}"
Copy link
Contributor

@hrai-nr hrai-nr Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing property RetentionInDays: 14


NewRelicLogsS3ARNConstructionLambdaIAMRole:
Type: "AWS::IAM::Role"
Properties:
Expand Down Expand Up @@ -306,6 +320,14 @@ Resources:
Timeout: 120
Role: !GetAtt NewRelicLogsS3ARNConstructionLambdaIAMRole.Arn

NewRelicLogsS3ARNConstructionLambdaLogGroup:
Type: AWS::Logs::LogGroup
DeletionPolicy: Delete
Condition: AddS3Trigger
Properties:
RetentionInDays: 14
LogGroupName: !Sub "/aws/lambda/${NewRelicLogsS3ARNConstructionLambda}"

NewRelicLogsResourceForS3ARNConstruction:
Type: AWS::CloudFormation::CustomResource
Condition: AddS3Trigger
Expand Down Expand Up @@ -425,6 +447,14 @@ Resources:
Timeout: 120
Role: !GetAtt NewRelicLogsLogGroupArnConstructionLambdaIAMRole.Arn

NewRelicLogsLogGroupArnConstructionLambdaLogGroup:
Type: AWS::Logs::LogGroup
DeletionPolicy: Delete
Condition: AddCloudwatchTrigger
Properties:
RetentionInDays: 14
LogGroupName: !Sub "/aws/lambda/${NewRelicLogsLogGroupArnConstructionLambda}"

NewRelicLogsResourceForLogGroupArnConstruction:
Type: AWS::CloudFormation::CustomResource
Condition: AddCloudwatchTrigger
Expand Down
8 changes: 8 additions & 0 deletions s3-trigger-stack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,14 @@ Resources:
Role: !GetAtt NewRelicLogsS3BucketTriggerIAMRole.Arn
Runtime: python3.12
Timeout: 120

NewRelicLogsS3BucketTriggerLambdaLogGroup:
Type: AWS::Logs::LogGroup
DeletionPolicy: Delete
Condition: HasValidS3Buckets
Properties:
RetentionInDays: 14
LogGroupName: !Sub "/aws/lambda/${NewRelicLogsS3BucketTriggerLambda}"

Outputs:
NewRelicLogsS3TriggerSetupErrors:
Expand Down
Loading