Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added support for trustboundary security events. #218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Added support for trustboundary security events. #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a4258b
Handling to generate trustboudary event
sumitsuthar Jun 4, 2024
64a8ee6
updated invocation for trustboundary
sumitsuthar Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/instrumentation-security/core/event-constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ const EVENT_TYPE = {
UNVALIDATED_REDIRECT: 'UNVALIDATED_REDIRECT',
REFLECTED_XSS: 'REFLECTED_XSS',
XPATH: 'XPATH',
LDAP: 'LDAP'
LDAP: 'LDAP',
TRUSTBOUNDARY: 'TRUSTBOUNDARY'
}
const EVENT_CATEGORY = {
MYSQL: 'MYSQL',
Expand All @@ -40,7 +41,8 @@ const EVENT_CATEGORY = {
UNVALIDATED_REDIRECT: 'UNVALIDATED_REDIRECT',
REFLECTED_XSS: 'REFLECTED_XSS',
XPATH: 'XPATH',
LDAP: 'LDAP'
LDAP: 'LDAP',
TRUSTBOUNDARY: 'TRUSTBOUNDARY'
}

module.exports = {
Expand Down
42 changes: 37 additions & 5 deletions lib/instrumentation-security/hooks/http/nr-http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

module.exports = initialize
const requestManager = require('../../core/request-manager');
const { NR_CSEC_FUZZ_REQUEST_ID, QUESTION_MARK, EMPTY_STRING, UTF8, CONTENT_TYPE, TEXT_HTML, APPLICATION_JSON, APPLICATION_XML, APPLICATION_XHTML, TEXT_PLAIN, APPLICATION_X_FORM_URLENCODED, MULTIPART_FORM_DATA, COMMA } = require('../../core/constants');
const { NR_CSEC_FUZZ_REQUEST_ID, QUESTION_MARK, EMPTY_STRING, UTF8, CONTENT_TYPE, TEXT_HTML, APPLICATION_JSON, APPLICATION_XML, APPLICATION_XHTML, TEXT_PLAIN, APPLICATION_X_FORM_URLENCODED, MULTIPART_FORM_DATA, COMMA, OBJECT } = require('../../core/constants');
const ARRAY_TYPE = 'Array';
const STRING_TYPE = 'string';
const BUFFER_TYPE = 'Buffer';
Expand Down Expand Up @@ -178,7 +178,7 @@ function parseFuzzheaders(requestData, transactionId) {
if (verifiedHash) {
logger.debug("Encrypted Data:", encryptedData);
logger.debug("Decrypted Data:", decryptedData)
logger.debug("fliesTocreate:",filesToCreate);
logger.debug("fliesTocreate:", filesToCreate);
for (let i = 0; i < filesToCreate.length; i++) {
let file = filesToCreate[i].trim();
file = file.replace(CSEC_HOME_TMP_CONST, CSEC_HOME_TMP);
Expand All @@ -192,11 +192,11 @@ function parseFuzzheaders(requestData, transactionId) {
logger.debug(parentDir + ' Already Exists');
}
fs.closeSync(fs.openSync(file, 'w'));

requestData.tempFiles = [];
requestData.tempFiles.push(file);
requestManager.setRequest(transactionId, requestData);

} catch (error) {
logger.debug(error);
}
Expand Down Expand Up @@ -396,8 +396,11 @@ function responseHook(resp, req, shim) {
}
return function wrappedEnd() {
const response = this;
responseBodyCompute(response, arguments);
const request = requestManager.getRequest(shim);
if (request) {
trustBoundaryCheck(response.req.session, shim)
}
responseBodyCompute(response, arguments);
const construct = API.checkForReflectedXSS(request, response.res.body, response.getHeaders());
const policy = API.getPolicy();
const dynamicScanningFlag = policy.data ? (policy.data.vulnerabilityScan?.enabled && policy.data.vulnerabilityScan.iastScan.enabled) : false;
Expand Down Expand Up @@ -565,4 +568,33 @@ function deleteTempFileForIAST(file) {
} catch (error) {
logger.debug("Unable to delete temporary file", error);
}
}

/**
* Utility to generate trustboundary events.
* @param {*} sessionObject
* @param {*} shim
*/
function trustBoundaryCheck(sessionObject, shim) {
try {
const request = requestManager.getRequest(shim);
let params = [];
Object.keys(sessionObject).forEach(key => {
if (sessionObject[key] && typeof sessionObject[key] != OBJECT) {
params.push(String(key));
params.push(String(sessionObject[key]));
}
});
if (!lodash.isEmpty(params)) {
const traceObject = secUtils.getTraceObject(shim);
const secMetadata = securityMetaData.getSecurityMetaData(request, params, traceObject, secUtils.getExecutionId(), EVENT_TYPE.TRUSTBOUNDARY, EVENT_CATEGORY.TRUSTBOUNDARY)
const secEvent = API.generateSecEvent(secMetadata);
API.sendEvent(secEvent);
}

} catch (error) {
logger.debug("Error while processing trustboundary", error);

}

}
Loading