Make timeout configurable (NR-281994) #315
Open
+127
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kang-makes
force-pushed
the
kang-makes/make-timeout-configurable
branch
2 times, most recently
from
d89c183
to
7cbbd57
Compare
kang-makes
force-pushed
the
kang-makes/make-timeout-configurable
branch
from
7cbbd57
to
e4b0c3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users increase the interval to (for example) 5 minutes, our samples appear broken because the cache TTL is set by default to 1 minute making RATES and DELTAS to report only 0’s / nulls.
This PR set TTL as a variable and rise the default to 6 minutes (5 minutes plus a sane amount of time in case the integrations takes too long to execute)