Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netty 'unknown' transactions #2274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

obenkenobi
Copy link
Contributor

Overview

The default start point for starting netty HTTP2 transactions were reverted to use io.netty.handler.codec.http2.Http2FrameCodec. This will stop the 'unknown' http2 transactions at a loss possible coverage of http2 requests in niche scenarios. To add such granularity at the cost of possibly receiving 'unknown', a new feature flag is added via the config:

common: &default_settings
...
  netty:
    http2:
      frame_read_listener:
        start_transaction: true

Related Github Issue

#2106

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.54%. Comparing base (0f181db) to head (7cd6ef4).
Report is 34 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2274      +/-   ##
============================================
- Coverage     70.60%   70.54%   -0.06%     
- Complexity     9995    10022      +27     
============================================
  Files           843      844       +1     
  Lines         40453    40569     +116     
  Branches       6130     6148      +18     
============================================
+ Hits          28562    28620      +58     
- Misses         9112     9168      +56     
- Partials       2779     2781       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants