-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling configuration of jfr params #371
base: main
Are you sure you want to change the base?
Conversation
@@ -18,12 +20,19 @@ | |||
public static final String AUDIT_LOGGING = "audit_logging"; | |||
public static final Boolean AUDIT_LOGGING_DEFAULT = Boolean.FALSE; | |||
public static final Boolean USE_LICENSE_KEY_DEFAULT = Boolean.TRUE; | |||
public static final String HARVEST_INTERVAL = "harvest_interval"; | |||
public static final String QUEUE_SIZE = "queue_size"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the intent is for these to be publicly configurable then we'll probably want them in the default yaml: https://github.com/newrelic/newrelic-java-agent/blob/main/newrelic-agent/src/main/resources/newrelic.yml#L274-L289
And also in the usage section of the readme: https://github.com/newrelic/newrelic-jfr-core#usage-for-new-relic-java-agent-jfr-service
Thats said, I'm not sure if the intent is for these to be publicized as of yet...
Feature Request submitted by a customer:
|
When deciding if the agent should impose limits on these new config options we should consider the limits imposed by the Metric API and Event API that JFR is sent to so that we can minimize the likelihood of data being rejected by the backend:
Also consider adding supportability metrics to record the values configured by customers to make troubleshooting easier. |
Overview
Enables configuration of queue size and harvest interval for JFR data.
Related Github Issue
newrelic/newrelic-jfr-core#203
Checks
Are your contributions backwards compatible with relevant frameworks and APIs?
Yes
Does your code contain any breaking changes? Please describe.
No
Does your code introduce any new dependencies? Please describe.
No