Fix typos and grammar in strings.xml #16005
Closed
+21
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
duvvuvenkataramana
commented
Nov 25, 2025
duvvuvenkataramana
commented
- Tests written, or not not needed
Signed-off-by: duvvuvenkataramana <[email protected]>
rakekniven
requested changes
Nov 25, 2025
Signed-off-by: duvvuvenkataramana <[email protected]>
Contributor
Author
|
@AndyScherzinger @rakekniven I changed and corrected some spellings. Review and Merge |
Member
|
@duvvuvenkataramana thanks for the changes, please see my comments. This won't compile since changing the ID for a string basically breaks the ID-reference in the java/kotlin code, so the app won't even compile anymore. |
Signed-off-by: duvvuvenkataramana <[email protected]>
| <item quantity="other">You can upload up to %d files at once.</item> | ||
| </plurals> | ||
| <string name="sync_foreign_files_forgotten_explanation">As of version 1.3.16, files uploaded from this device are copied into the local %1$s folder to prevent data loss when a single file is synced with multiple accounts.\n\nDue to this change, all files uploaded with earlier versions of this app were copied into the %2$s folder. However, an error prevented the completion of this operation during account synchronization. You may either leave the file(s) as is and delete the link to %3$s, or move the file(s) into the %1$s folder and retain the link to %4$s.\n\nListed below are the local file(s), and the remote file(s) in %5$s they were linked to.</string> | ||
| <string name="sync_foreign_files_forgotten_explanation">As of version 1.3.16, files uploaded from this device are copied into the local %1$s folder to prevent data loss when a single file is sycned with multiple accounts.\n\nDue to this change, all files uploaded with earlier versions of this app were copied into the %2$s folder. However, an error prevented the completion of this operation during account synchronization. You may either leave the file(s) as is and delete the link to %3$s, or move the file(s) into the %1$s folder and retain the link to %4$s.\n\nListed below are the local file(s), and the remote file(s) in %5$s they were linked to.</string> |
Member
There was a problem hiding this comment.
This adds a typo and is not removing one!
Contributor
Author
There was a problem hiding this comment.
this is correct one
Member
|
Hi @duvvuvenkataramana quick question, are you vibe coding this? I am asking because
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.