Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

We use KAPT only for creating language for MarkwonGrammarLocator.
I now replaced it with pre-built version.

This saves on my machen 20s per each full run.

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <[email protected]>
@github-actions
Copy link

Codacy

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7373
Dodgy code275275
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4848
Security1818
Total501501
org.jetbrains.annotations.* is used. Please use androidx.annotation.* instead.

@github-actions
Copy link

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16018.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

false,
"property",
grammar("inside",
token("string", pattern(compile("(#\\s*include\\s*)(?:<.+?>|(\"|')(?:\\\\?.)+?\\2)"), true)),

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with '#include"' and containing many repetitions of '\a'.
token(
"template-string",
pattern(
compile("`(?:\\\\[\\s\\S]|\\$\\{[^}]+\\}|[^\\\\`])*`"),

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with '`' and containing many repetitions of '${[}'.
GrammarUtils.require(prism4j, "clike"),
"swift",
token("string", pattern(
compile("(\"|')(\\\\(?:\\((?:[^()]|\\([^)]+\\))+\\)|\\r\\n|[\\s\\S])|(?!\\1)[^\\\\\\r\\n])*\\1"),

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with '"\' and containing many repetitions of '(')\'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants