Skip to content

Feat/federated sharing - #8184

Draft
luka-nextcloud wants to merge 8 commits into
mainfrom
feat/federated-sharing
Draft

luka-nextcloud wants to merge 8 commits into
mainfrom
feat/federated-sharing

Conversation

@luka-nextcloud

Copy link
Copy Markdown
Contributor
  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@github-actions

Copy link
Copy Markdown
Contributor

馃悽 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96828 was 96706 (+0.12%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions

Copy link
Copy Markdown
Contributor

馃悽 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 206554 was 198420 (+4.09%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@luka-nextcloud

Copy link
Copy Markdown
Contributor Author

@CarlSchwan @come-nc I would need advice from experts of files_sharing app:
What is the correct way to mount the endpoint and ensure the remote share file is visible right after accepted the remote share (after called $this->externalManager->acceptShare($externalShare))?

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud
luka-nextcloud force-pushed the feat/federated-sharing branch from 1eca4c9 to 38e34df Compare October 6, 2026 06:58
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

馃悽 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 205527 was 198420 (+3.58%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

馃悽 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 205990 was 198420 (+3.81%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant