Repository navigation
fix: keep the description editor menu above tables - #8426
mael-chouteau wants to merge 2 commits into
Conversation
The sidebar override set the Text menubar to z-index 1, so its dropdowns painted under table widgets. Use 4 so the menu stays above those widgets and still below tag menus and the sticky sidebar header. Fixes nextcloud#7789 Signed-off-by: chouteau Ma毛l <chouteaumael@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This branch has not been deployed
1 participant
Summary
The formatting menu in a card description was sliding under tables. Deck forced that menu to
z-index: 1, while the Text editor draws table controls atz-index: 3. Because the menu is sticky, that low value also trapped its dropdowns underneath the table.This raises the sidebar menu to
z-index: 4, the same level the Text app uses for this bar. That is high enough to paint above tables, and still low enough to stay under the tag and user menus (50) and the sticky card header (100). A much higher value would cover those menus again, which is what happened when this override was100.Fixes #7789
TODO
Checklist
No automated test covers this stacking order. The change is one CSS value, chosen to sit between the existing layers.