fix(ui): skip creating empty drafts - #13711
Open
abhinavohri wants to merge 1 commit into
Open
abhinavohri wants to merge 1 commit into
abhinavohri wants to merge 1 commit into
Conversation
The draft guard checked body.value, but composer data uses bodyHtml or bodyPlain. Check the editor content in the shared draft save path and ignore automatic signatures. Assisted-by: Codex:gpt-5 Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
abhinavohri
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
September 21, 2026 10:01
Contributor
Author
|
One related case remains unchanged: If a user enters some content and waits for autosave, a draft is created. If they then remove all content and close the composer, the existing draft remains because it has already been saved. Should an existing draft be deleted when the composer becomes completely empty? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Empty drafts could be created in two cases:
body.value, but composer data usesbodyHtmlorbodyPlain, so an empty body was not detected.This change checks the actual editor content, ignores the automatic signature when determining whether the body is empty, and applies the guard through the shared draft save path used by autosave and closing.
Fixes #13291