fix: AppSettings using bad notes-path for file picker #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g delete Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
…set manually Signed-off-by: Julius Härtl <[email protected]>
…4.10 [stable4.10] fix/shared notes
…4.10 [stable4.10] fix: Switch to vue-frag instead of vue-fragment to avoid errors during delete
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
…4.10 [stable4.10] fix: webpack chunk loading
Signed-off-by: Thibault Poisson <[email protected]>
|
Hi @OrIOg and thank you for your contribution! The same fix was contributed in another PR which goes against the main branch of this repo. Hence closing this PR. Still thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the bug of the filepicker discovered after the merge of #1341 to fix the issue specified by #1186 (comment)
Tested the fix on Nextcloud(AIO): 29.0.2.2 with Firefox128.0.3 (64-bit).