Repository navigation
fix(dav): store webcal subscription credentials encrypted - #65705
Open
SebastianKrupinski wants to merge 1 commit into
Open
SebastianKrupinski wants to merge 1 commit into
SebastianKrupinski wants to merge 1 commit into
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
requested review from
a team,
ChristophWurst and
tcitworld
as code owners
October 19, 2026 19:19
SebastianKrupinski
requested review from
Altahrim,
leftybournes,
salmart-dev and
sorbaugh
and removed request for
a team
October 19, 2026 19:19
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
Yes there are better ways to do this then creating the crypto library with "Server::get(ICrypto::class)". But since this is only needed for 2 operations I didn't think complicating this fix by injecting the class in the constructors was worth it, as it would require modifying event more files from the server.php to console commands |
Closed
2 of 8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: Support webcal http auth & store credentials calendar#70
Credentials in the user info of a subscription source URL were stored in plain text and returned to clients as part of the source. They were also used without percent-decoding, so Basic auth failed for passwords containing characters such as '@', ':' or '#'.
On create and update, split the user info off the source, percent-decode it and store it encrypted in the new calendarsubscriptions.credentials column. Sending back an unchanged source without user info keeps the stored credentials. Existing subscriptions are migrated. Credentials are decrypted when listing a user's subscriptions and used for Basic auth when the feed is refreshed.
Checklist
3. to review, feature component)stable32)AI (if applicable)