Repository navigation
feat(2fa): allow apps to ask for the second factor again in a session - #65741
Draft
karlitschek wants to merge 1 commit into
Draft
karlitschek wants to merge 1 commit into
karlitschek wants to merge 1 commit into
Conversation
Add IChallengeRequester. It marks the current session as needing the second factor again, using the same mechanism as the login, so core's two-factor middleware redirects every request of the session to the challenge until it is solved and then returns to the given URL. Apps can use it to confirm it is really the user before a sensitive action in a session that looks suspicious. Sessions created with an app password cannot answer a challenge and are refused. Assisted-by: ClaudeCode:claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
This was referenced Oct 20, 2026
Contributor
|
Sounds more like we want password confirmation with second factor instead. This just duplicates what we already have with password confirmation. I think there is even a feature request for it |
nickvergessen
left a comment
nickvergessen
left a comment
Member
There was a problem hiding this comment.
I think this makes sense. But I don't see how this triggers in the server atm. Let's say e.g. a user is on Talk, this triggers "randomly" on grabbing chat messages. Which part is taking care of requiring the 2FA again? Frontend, with a hard redirect? Backend blocking all requests but being unable to redirect the user?
This was referenced Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One of seven small, independent core changes needed by a planned
intrusion_detectionapp. Each can be reviewed and merged on its own:AppPasswordCreatedEvent, dispatched everywhereIProvider::invalidateTokenById()in the public token providerShareLinkAccessFailedEventPasswordResetRequestedEventIChallengeRequester: ask for the second factor again in a session ← this PRTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
AI disclosure: this change was written with Claude Code (claude-opus-5-5) and reviewed by the author; every commit carries an
Assisted-bytrailer.🤖 Generated with Claude Code