fix(AdminSettings): migrate to NcSettingsSection #12840
Draft
+73
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
2. developing
design
feature: settings ⚙️
ShGKme
force-pushed
the
fix/admin-settings--migrate-to-NcSettingsSection
branch
from
125a534
to
702f3b7
Compare
| class="federation" | ||
| :name="t('spreed', 'Federation')" | ||
| doc-url="https://docs.nextcloud.com/server/latest/user_manual/en/talk/advanced_features.html#federated-conversation"> | ||
| <!-- <small>{{ t('spreed', 'Beta') }}</small> --> |
There was a problem hiding this comment.
Then it loses all the "badge" styles
| class="matterbridge" | ||
| :name="t('spreed', 'Matterbridge integration')" | ||
| doc-url="https://nextcloud-talk.readthedocs.io/en/latest/matterbridge/"> | ||
| <!-- <small>{{ t('spreed', 'Beta') }}</small> --> |
There was a problem hiding this comment.
- Missing features:
- BETA badge
Requires some adjustments on NcSettingsSection 😶
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/admin-settings--migrate-to-NcSettingsSection
branch
from
702f3b7
to
6e5ca59
Compare
| <NcSettingsSection id="stun_server" | ||
| :name="t('spreed', 'STUN servers')" | ||
| :description="t('spreed', 'A STUN server is used to determine the public IP address of participants behind a router.')" | ||
| doc-url="https://nextcloud-talk.readthedocs.io/en/latest/TURN/"> |
There was a problem hiding this comment.
It is not, but on the TURN page (the "configuration/overview" page) there is a small paragraph describing what is STUN and when it is necessary.
- Talk tries to establish a direct peer-to-peer (P2P) connection, thus on connections beyond the local network (behind a NAT or router), clients do not only need to know each other's public IP, but the participants local IPs as well. Processing this, is the job of a STUN server. As there is one preconfigured for Nextcloud Talk that is operated by Nextcloud GmbH, for this case nothing else needs to be done.
Better to link to a Wiki article directly?
There was a problem hiding this comment.
I would say either it should be a useful installation/setup/configuration manual or we don't add a link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcSettingsSectionfor design consistencyBETAbadge🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist