Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(call): list participants grid/stripe with a mouse wheel #13219

Merged
merged 2 commits into from
Sep 23, 2024
Merged

feat(call): list participants grid/stripe with a mouse wheel #13219

merged 2 commits into from
Sep 23, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 6, 2024

☑️ Resolves

  • Allows to change pages in call grid with a mouse wheel scrolling

⚠️ Second commited is not to be backported!

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

2024-09-06_17h26_46

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 6, 2024
@Antreesy Antreesy self-assigned this Sep 6, 2024
DorraJaouad
DorraJaouad approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good but still need to be mentioned somewhere so the user can know about it (maybe shortcuts ?)

@Antreesy Antreesy merged commit dea8750 into main Sep 23, 2024
46 checks passed
@Antreesy Antreesy deleted the feat/noid/scroll-participants-in-call branch September 23, 2024 10:43
@Antreesy
Copy link
Contributor Author

/backport 96f8580 to stable30

@backportbot backportbot bot mentioned this pull request Sep 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad