Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(avatar): adjust svg template and center emoji avatar #13273

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(avatar): adjust svg template and center emoji avatar #13273

wants to merge 1 commit into from
+2 −2

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 11, 2024 •
edited
Loading

☑️ Resolves

vertically centers emoji in emoji-avatar

Important

For prepared - requires to create new avatars
For inline emojis - works on hard reload

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

See in comments

🚧 Tasks

  • Test on different OS:
    • Windows
    • Linux
    • MacOS

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@Antreesy Antreesy added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 labels Sep 11, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 11, 2024
@Antreesy Antreesy self-assigned this Sep 11, 2024
@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 11, 2024 •
edited
Loading

Nvm, it was only visuall aligned

UPD: aligned differently, but still may vary depending on font

2024-09-11_22h57_54

@Antreesy Antreesy marked this pull request as draft September 11, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
1 participant
@Antreesy