fix(Call): introduce intermediary phase before joining call #13329
+130
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t. It's only received when using internal server. Replace them with events from the base class so we make sure it's always received. Also, add a new event for failed joining Signed-off-by: DorraJaouad <[email protected]>
…nCall, connecting, connection failed) Signed-off-by: DorraJaouad <[email protected]>
…roduce a failed join message dialog. Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
commented
Sep 17, 2024
Comment on lines
-808
to
-812
| setTimeout(() => { | ||
| // If by accident we never receive a users list, just switch to | ||
| // "Waiting for others to join the call …" after some seconds. | ||
| commit('finishedConnecting', { token, sessionId: participantIdentifier.sessionId }) | ||
| }, 10000) |
There was a problem hiding this comment.
It's guaranteed to receive one of the above signaling events as we are the base server
Antreesy
reviewed
Sep 18, 2024
| @@ -321,27 +321,29 @@ const mutations = { | |||
| if (state.inCall[token] && state.inCall[token][sessionId]) { | |||
| Vue.delete(state.inCall[token], sessionId) | |||
| } | |||
|
|
|||
| if (state.connecting[token] && state.connecting[token][sessionId]) { | |||
There was a problem hiding this comment.
I think we can keep this resetting (in case it survives somehow). Maybe via commit('finishedConnecting')?
| import NcEmptyContent from '@nextcloud/vue/dist/Components/NcEmptyContent.js' | ||
| import NcModal from '@nextcloud/vue/dist/Components/NcModal.js' | ||
|
|
||
| import store from '../../store/index.js' |
There was a problem hiding this comment.
we have useStore composable, it should be better to use it here
| @@ -36,6 +36,7 @@ const joinCall = async function(token, flags, silent, recordingConsent) { | |||
| return await signalingJoinCall(token, flags, silent, recordingConsent) | |||
| } catch (error) { | |||
| console.debug('Error while joining call: ', error) | |||
| throw error | |||
There was a problem hiding this comment.
maybe remove try-catch block here, since it's not needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Before
Recording.2024-09-17.160718.mp4
After
Recording.2024-09-17.160913.mp4
🏁 Checklist