Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate sounds store to Pinia 🍍 #13356

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

Antreesy
Copy link
Contributor

β˜‘οΈ Resolves

  • Fix nothing
  • Break nohing

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possible

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring πŸ¦…

src/stores/sounds.js Outdated Show resolved Hide resolved
src/stores/sounds.js Outdated Show resolved Hide resolved
src/components/MediaSettings/MediaDevicesSpeakerTest.vue Outdated Show resolved Hide resolved
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/sounds-store-to-pinia branch from c594b18 to e79fae2 Compare September 23, 2024 12:58
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested βœ…

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/sounds-store-to-pinia branch from e79fae2 to e94fb54 Compare September 25, 2024 06:13
@Antreesy Antreesy merged commit 87a16f4 into main Sep 25, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/sounds-store-to-pinia branch September 25, 2024 06:16
@Antreesy
Copy link
Contributor Author

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants