-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(audioPlayer): Auto play voice messages which are grouped together #13360
feat(audioPlayer): Auto play voice messages which are grouped together #13360
Conversation
src/components/MessagesList/MessagesGroup/Message/MessagePart/AudioPlayer.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the contribution!
I see the current implementation a bit overcomplicated, please see comments
src/components/MessagesList/MessagesGroup/Message/MessagePart/AudioPlayer.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/AudioPlayer.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/AudioPlayer.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/AudioPlayer.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/AudioPlayer.vue
Show resolved
Hide resolved
Hi, just tested the PR. Works nice! Also looks good code-wise, left a fixup commit to reduce unneccessary changes. Waiting for @DorraJaouad approval, then we can squash and merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ✅
Code-wise ✅
Signed-off-by: Souptik Datta <[email protected]>
4ef10eb
to
adf1b62
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
/backport to stable30 |
☑️ Resolves
Note: In Whatsapp (whose example is given in the issue), the voice messages auto-play only when they are grouped together. Therefore I tried to replicate that only. If there's a message between two voice messages, it will not be auto-played.
That being said, its very easy to change this behaviour. We just need to remove this
since
check over here.🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Before
Before.mov
After
After.mov
🏁 Checklist