Repository navigation
🔄 synced file(s) with nextcloud/android-config - #6804
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR feedback workflow now pins Priority: ⬇️ Low Merge Risk: 🔵 Low · up to Older PRs may no longer receive an automatic feedback request when an author becomes eligible. Confirm whether that limit is intended, or disable it to preserve the previous behavior. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
f5872afb-c4d8-4395-9108-dd2e3ce198f7
📒 Files selected for processing (1)
.github/workflows/pr-feedback.yml
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
| echo "blocklist=$blocklist" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - uses: nextcloud/pr-feedback-action@4709fa5b3e1821559d4c312ef937b61f1567aa44 # main | ||
| - uses: nextcloud/pr-feedback-action@4738cf661995d96df3512409ec17c900a4081d33 # main |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
sed -n '1,100p' .github/workflows/pr-feedback.yml
rg -n 'max-days-overdue|days-before-feedback|exempt-authors|pr-feedback-action' .github config 2>/dev/nullRepository: nextcloud/talk-android
Length of output: 3200
🏁 Script executed:
#!/bin/bash
set -u
printf '%s\n' '--- PR workflow diff ---'
git diff --no-ext-diff --unified=12 baaca43d5b03139b5b68b172cb1dc61fe68972ab f1b91b576b1fbfee2a5434bf715b60a6e2d5461e -- .github/workflows/pr-feedback.yml
printf '%s\n' '--- workflow at merge base ---'
git show baaca43d5b03139b5b68b172cb1dc61fe68972ab:.github/workflows/pr-feedback.yml 2>&1 | sed -n '30,65p'
printf '%s\n' '--- action trees ---'
for sha in 4709fa5b3e1821559d4c312ef937b61f1567aa44 4738cf661995d96df3512409ec17c900a4081d33; do
echo "REVISION $sha"
curl -fsSL --max-time 20 "https://api.github.com/repos/nextcloud-libraries/pr-feedback-action/git/trees/$sha?recursive=1" |
python3 -c 'import json,sys; x=json.load(sys.stdin); print("\n".join(i["path"] for i in x.get("tree",[]) if any(s in i["path"].lower() for s in ("action.yml","readme","test","spec","src","index"))))' || echo "tree fetch failed"
doneRepository: nextcloud/talk-android
Length of output: 7313
🏁 Script executed:
python3 - <<'PY'
import json, urllib.request, difflib
base = "https://api.github.com/repos/nextcloud-libraries/pr-feedback-action"
old = "4709fa5b3e1821559d4c312ef937b61f1567aa44"
new = "4738cf661995d96df3512409ec17c900a4081d33"
url = f"{base}/compare/{old}...{new}"
req = urllib.request.Request(url, headers={"Accept": "application/vnd.github+json", "User-Agent": "read-only-review"})
with urllib.request.urlopen(req, timeout=25) as r:
data = json.load(r)
print("COMPARE", data.get("status"), "commits", data.get("ahead_by"))
for f in data.get("files", []):
print(f"\n--- {f['filename']} ({f['status']}, additions={f['additions']}, deletions={f['deletions']}) ---")
patch = f.get("patch")
if patch:
print(patch)
else:
print("[no patch returned]")
PYRepository: nextcloud/talk-android
Length of output: 2446
🏁 Script executed:
set -o pipefail
curl -fsSL --max-time 25 -H 'Accept: application/vnd.github+json' -H 'User-Agent: read-only-review' 'https://api.github.com/repos/nextcloud-libraries/pr-feedback-action/compare/4709fa5b3e1821559d4c312ef937b61f1567aa44...4738cf661995d96df3512409ec17c900a4081d33' |
python3 -c 'import json,sys; d=json.load(sys.stdin); print("status",d.get("status"),"ahead_by",d.get("ahead_by")); [print("\n---",f["filename"],"("+f["status"]+", +"+str(f["additions"])+"/-"+str(f["deletions"])+") ---\n"+f.get("patch","[no patch returned]")) for f in d.get("files",[])]'Repository: nextcloud/talk-android
Length of output: 42879
🏁 Script executed:
curl -fsSL --max-time 20 'https://raw.githubusercontent.com/nextcloud/.github/master/workflow-templates/pr-feedback.yml' | nl -ba | sed -n '1,100p'Repository: nextcloud/talk-android
Length of output: 3253
Preserve the workflow’s previous feedback eligibility.
The previous pin had no overdue cap. With this pin, the default seven-day cap can skip a PR more than 21 days old, including one whose author is removed from exempt-authors. Set max-days-overdue: -1 to retain the previous behavior.
🐛 Suggested fix
days-before-feedback: 14
+ max-days-overdue: -1
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
60b8f71 to
a479578
Compare
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
a479578 to
1f3804f
Compare
2 participants
synced local file(s) with nextcloud/android-config.
Changed files
.github/workflows/with remote directoryconfig/workflows/This PR was created automatically by the repo-file-sync-action workflow run #37436808047