Skip to content

add subtitles for video feature #239

Closed as not planned
Closed as not planned

Description

@caythanhgia

add this code to Videos.vue : template->video support many subtitle
`

	<track
		:src="davPath.replace(/\.[^\.]+$/, '.vi.vtt')"
		label="Vietnamess"
		kind="captions"
		srclang="vi-vn" default />`

Activity

  1. skjnldsv commented on Sep 9, 2019

    @skjnldsv
    Member

    Any files to give me a working example?
    Also please use the appropriate issues templates tex time :)

  2. added
    0. Needs triagePending approval or rejection. This issue is pending approval.
    enhancementNew feature or request
    on Sep 9, 2019
  3. added
    1. to developAccepted and waiting to be taken care of
    and removed
    0. Needs triagePending approval or rejection. This issue is pending approval.
    on Apr 27, 2020
  4. douzebis commented on May 17, 2021

    @douzebis
    Member

    Hi @skjnldsv
    Indeed captions would be a nice addition to the viewer.
    And it seems we could leverage plyr.io support for HTML5 captions to provide the feature at a low cost?
    Is there no traction for this?

  5. douzebis commented on May 19, 2021

    @douzebis
    Member

    I just tested the patch below.
    Does quite a decent job.
    I might send a pull request?

    diff --git a/src/components/Videos.vue b/src/components/Videos.vue
    index 727939b..007c203 100644
    --- a/src/components/Videos.vue
    +++ b/src/components/Videos.vue
    @@ -41,6 +41,17 @@
                                    @ended="donePlaying"
                                    @canplay="doneLoading"
                                    @loadedmetadata="onLoadedMetadata">
    +                               <track
    +                                       :src="davPath.replace(/\.[^\.]+$/, '.en.vtt')"
    +                                       label="English"
    +                                       kind="captions"
    +                                       srclang="en"
    +                                       default />`
    +                               <track
    +                                       :src="davPath.replace(/\.[^\.]+$/, '.fr.vtt')"
    +                                       label="French"
    +                                       kind="captions"
    +                                       srclang="fr" />`
     
                                    <!-- Omitting `type` on purpose because most of the
                                            browsers auto detect the appropriate codec.
    
  6. linked a pull request that will close this issueAdd support for movie captions #907on May 23, 2021
  7. linked a pull request that will close this issueAdd support for video captions #910on May 23, 2021
  8. MeowMeowVenom commented on Jun 21, 2021

    @MeowMeowVenom

    Plyr.io supports only .vtt (its more like HTML5 thing)
    https://github.com/maple3142/GDIndex

    The above index, has support for .srt files too.

  9. douzebis commented on Jun 21, 2021

    @douzebis
    Member

    Plyr.io supports only .vtt (its more like HTML5 thing)
    https://github.com/maple3142/GDIndex

    The above index, has support for .srt files too.

    Actually, pull request #915 will provide .srt-like support for plyr.io.
    It is already working and (I reckon) just lacks unit tests before it can be merged into master.
    Unfortunately I have no time at the moment to complete the job :(

  10. pinned this issue on Dec 16, 2021
  11. PVince81 commented on Aug 22, 2022

    @PVince81
    Member

    supporting anything else than vtt files will require to have an endpoint to is able to extract subtitles from the video and expose them as a conversion to vtt.

    there might be libraries that do it (I seem to remember a Node JS based one)

    maybe the generated vtt file could be cached in appdata like image previews after extracting+generating

  12. unpinned this issue on Aug 9, 2024
  13. VincentX0905 commented on Mar 18, 2026

    @VincentX0905

    This question has existed for a long time. Is it even possible to achieve this...?

  14. Xplouder commented on Mar 18, 2026

    @Xplouder

    @douzebis what happened with #915 ? it actually got merged? i see it closed and removed from version 27 milestones...

  15. douzebis commented on Mar 19, 2026

    @douzebis
    Member

    @Xplouder yes it was merged. By John Molakvoæ I reckon.
    It used to work. But I have not tested it in a long time.

  16. skjnldsv commented on Mar 19, 2026

    @skjnldsv
    Member

    No it was not, the PR was staled and too complicated to revive. This ticket is still up for takesies

  17. moved this from To triage to Backlog in 🧑‍🤝‍🧑 Community triageon Jul 14, 2026
  18. susnux commented on Oct 25, 2026

    @susnux
    Contributor

    Thank you for the suggestion and for taking the time to report it.

    The Nextcloud Viewer is no longer developed as a standalone app. Its code has moved to the @nextcloud/viewer library, which is now maintained at https://github.com/nextcloud-libraries/nextcloud-viewer. Because of this, we will not add any further enhancements to this repository and are closing open feature requests here.

    If you are still interested in this feature, please open a new feature request in the library repository:
    https://github.com/nextcloud-libraries/nextcloud-viewer/issues/new/choose

    Feel free to link back to this issue so the existing discussion is not lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    1. to developAccepted and waiting to be taken care ofenhancementNew feature or requestwontfixThis will not be worked on

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions