Skip to content

Fix LVM snapshot and disk space logic (closes #1986) #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enoch85 merged 2 commits into from
Nov 4, 2025
Merged

Fix LVM snapshot and disk space logic (closes #1986) #2779

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be11318
Fix LVM snapshot and disk space logic (closes #1986)
enoch85 Nov 4, 2025
dc89b5e
Export and unset SNAPSHOTS_ENABLED and USE_ALL_DISK_SPACE variables
enoch85 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions nextcloud_install_production.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ if dpkg-query -W -f='${Status}' "whiptail" 2>/dev/null | grep -q "ok installed"
then
echo "whiptail OK"
else
apt-get update -q4
apt-get install whiptail -y
fi

Expand Down Expand Up @@ -99,6 +100,8 @@ then
fi

# Create a placeholder volume before modifying anything
# Ask about snapshots first
export SNAPSHOTS_ENABLED=""
if [ -z "$PROVISIONING" ]
then
if ! does_snapshot_exist "NcVM-installation" && yesno_box_no "Do you want to use LVM snapshots to be able to restore your root partition during upgrades and such?
Expand All @@ -113,7 +116,8 @@ Enabling this will also force an automatic reboot after running the update scrip
print_text_in_color "$ICyan" "Creating volume..."
sleep 1
# Create a placeholder snapshot
check_command lvcreate --size 5G --name "NcVM-installation" ubuntu-vg
check_command lvcreate --size 10G --name "NcVM-installation" ubuntu-vg
export SNAPSHOTS_ENABLED="yes"
else
print_text_in_color "$IRed" "Could not create volume because of insufficient space..."
sleep 2
Expand All @@ -122,10 +126,21 @@ Enabling this will also force an automatic reboot after running the update scrip
fi

# Fix LVM on BASE image
# Ask about disk space - now snapshots have been reserved, we can use remaining space
export USE_ALL_DISK_SPACE=""
if grep -q "LVM" /etc/fstab
then
# In provisioning mode, always extend
# In normal mode, ask the user
if [ -n "$PROVISIONING" ] || yesno_box_yes "Do you want to make all free space available to your root partition?"
then
export USE_ALL_DISK_SPACE="yes"
fi
fi

# Extend LVM if requested
if [ "$USE_ALL_DISK_SPACE" = "yes" ]
then
# Resize LVM (live installer is &%¤%/!
# VM
print_text_in_color "$ICyan" "Extending LVM, this may take a long time..."
Expand All @@ -150,9 +165,12 @@ then
fi
fi
done
fi
fi

# Cleanup environment variables
unset SNAPSHOTS_ENABLED
unset USE_ALL_DISK_SPACE

# Install needed dependencies
install_if_not lshw
install_if_not net-tools
Expand Down