Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull and run treat Github usernames as case sensitive on Linux #5280

Open
harper357 opened this issue Sep 3, 2024 · 3 comments
Open

pull and run treat Github usernames as case sensitive on Linux #5280

harper357 opened this issue Sep 3, 2024 · 3 comments

Comments

@harper357
Copy link

harper357 commented Sep 3, 2024

Bug report

Expected behavior and actual behavior

I mention both pull and run because that is how I found the bug, but I confirmed it with just pull.

Expected:
Calling nextflow pull nextflow-io/hello or nextflow pull Nextflow-io/hello should pull/update the same pipeline.

Actual:
Calling these two above commands generates two different folders in $NXF_HOME/assets:

Steps to reproduce the problem

nextflow pull Nextflow-io/hello
Checking Nextflow-io/hello ...
 downloaded from https://github.com/nextflow-io/hello.git - revision: afff16a9b4 [master]nextflow pull nextflow-io/hello
Checking nextflow-io/hello ...
 downloaded from https://github.com/nextflow-io/hello.git - revision: afff16a9b4 [master]ls $NXF_HOME/assets/
nextflow-io/ Nextflow-io/

Environment

  • Nextflow version: 24.04.4 build 5917
  • Java version: OpenJDK 64-Bit Server VM 11.0.22+7-LTS
  • Operating system: Red Hat Enterprise Linux 9.3 (Plow) Linux 5.14.0-362.24.1.el9_3.x86_64
  • Bash version: GNU bash, version 5.1.8(1)-release (x86_64-redhat-linux-gnu)

Additional context

Slack discussion

@harper357

This comment was marked as resolved.

@pditommaso
Copy link
Member

What it could be investigate if there's a way to use the GitHub URI as source of truth to name to local path.

@ewels
Copy link
Member

ewels commented Sep 16, 2024

Yup, so taking the first example:

Checking Nextflow-io/hello ...
 downloaded from https://github.com/nextflow-io/hello.git - revision: afff16a9b4 [master]
  1. Nextflow looks for Nextflow-io/hello
  2. Nextflow finds https://github.com/nextflow-io/hello.git
  3. Nextflow creates the assets directory based on the remote name + capitlisation: nextflow-io/hello

This way there will only ever be one capitalisation possible for assets on any given pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants