Conversation
mrgoonie
force-pushed
the
chore/pin-package-manager
branch
from
September 23, 2026 10:20
978c3ea to
62c8fb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packageManagertopnpm@10.34.5so installs resolve a reproducible pnpm version instead of whichever pnpm happens to be installed on the machine. The repo had nopackageManagerfield, so tooling silently followed the global pnpm and drifted between machines.version:input from thepnpm/action-setupstep(s).pnpm/action-setupaborts withERR_PNPM_BAD_PM_VERSION("Multiple versions of pnpm specified") whenever both the workflowversion:input andpackageManagerare set, so leaving both would break CI.Why this version
10.34.5matches the pnpm major this repo's CI already installed, so CI behaviour is unchanged.packageManagerbecomes the single source of truth and the workflow no longer declares a version.Scope
pnpm-lock.yaml..github/workflows/ci.yml.github/workflows/deploy-mcp.yml.github/workflows/release.ymlpackage.jsonTest plan
pnpm install --frozen-lockfilestill passes