Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
runner.conda: Ignore newly failing type check for tarfile.open()
This started failing recently with newer typeshed stubs for tarfile.open() (and/or newer stubs for requests.Response?). mypy fails with: nextstrain/cli/runner/conda.py:220: error: Argument "fileobj" to "open" has incompatible type "Union[HTTPResponse, Any]"; expected "Optional[IO[bytes]]" and pyright with: nextstrain/cli/runner/conda.py:220:14 - error: No overloads for "open" match the provided arguments (reportCallIssue) nextstrain/cli/runner/conda.py:220:58 - error: Argument of type "Literal['r|*']" cannot be assigned to parameter "mode" of type "_FileCreationModes" in function "open" Type "Literal['r|*']" is not assignable to type "_FileCreationModes" "Literal['r|*']" is not assignable to type "Literal['a']" "Literal['r|*']" is not assignable to type "Literal['w']" "Literal['r|*']" is not assignable to type "Literal['x']" (reportArgumentType) I'm guessing the difference is because they match the different overloads of tarfile.open(). I dug into it a little¹, but the stubs here seem a bit scattershot at the moment so I stopped and went with an ignore. An alternative fix is casting response.raw to BinaryIO, but that seemed uglier and worse than an ignore. ¹ See <python/typeshed#12117> (implicated) and <python/typeshed#12181> (open, may fix?) and <python/typeshed#12182> (open, may fix?)
- Loading branch information