chore: Remove cache strike notification#2088
Merged
collinjackson merged 3 commits intomainfrom Mar 17, 2026
Merged
Conversation
Fix formatting issues introduced in #2050: trailing whitespace in doc comments, method chain indentation, and inline if/else expansion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test address had mixed case that doesn't pass EIP-55 checksum validation introduced in #2050, causing test failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Removes the rewards_processed notification feature that displayed a "You've hit a cache of points!" overlay in the TUI header. This includes removing the REWARDS_EVENT_SENDER, Worker::Rewards event type, show_rewards_overlay state, show_mock_notification debug flag, and all associated wiring through analytics, runtime, events, and UI layers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Visit the preview URL for this PR (updated for commit 1be8742): https://nexus-cli--pr2088-remove-cache-strike-hd1hhx5k.web.app (expires Tue, 24 Mar 2026 21:08:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 815ec4c632754f56eccfacfc0919559f5a85a0f1 |
collinjackson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rewards_processednotification feature ("You've hit a cache of points!") from the TUI headerWorker::Rewardsevent type andrewards_with_levelconstructorREWARDS_EVENT_SENDER,set_rewards_event_sender, and response-parsing logic inreport_proving_if_neededshow_rewards_overlaystate and the hidden--show-mock-notificationdebug CLI flagTest plan
cargo buildpasses cleanly🤖 Generated with Claude Code